rpl: update routing table information for all dodags by cgundogan · Pull Request #2607 · RIOT-OS/RIOT

cgundogan · 2015-03-16T09:29:08Z

In the current implementation only the default dodag's routing table information is updated periodically. This PR extends this to iterate over all used dodags instead.

cgundogan · 2015-03-19T10:47:46Z

rebased to address @OlegHahm's comment mentioned #2622

OlegHahm · 2015-03-19T16:23:21Z

needs rebasing

cgundogan · 2015-03-19T17:40:40Z

@OlegHahm according to github this PR can be automatically merged 😕

OlegHahm · 2015-03-19T17:52:34Z

But cgundogan@d7722c1 which is part of this PR got already merged, didn't it?

cgundogan · 2015-03-19T17:53:32Z

ah, you are right. will rebase

cgundogan · 2015-03-19T18:03:23Z

rebased to current master

cgundogan · 2015-03-24T10:17:26Z

@OlegHahm any objection?

BytesGalore · 2015-03-30T13:46:14Z

sys/net/routing/rpl/rpl.c

This should be outside the DODAG iteration

Good catch, I will update and rebase this PR

cgundogan · 2015-03-31T08:14:17Z

addressed @BytesGalore comment. Rebased

cgundogan · 2015-04-07T07:26:18Z

ping @OlegHahm @BytesGalore @gebart . any ACKs? The change is small but it's important to handle the lifetimes of multiple dodags. Otherwise only the dodag's lifetime gets decreased, which is returned by rpl_get_my_dodag(). I want to eliminate the dependency to this function (rpl_get_my_dodag()) in the long(actually short) run.

BytesGalore · 2015-04-07T07:46:51Z

sys/net/routing/rpl/rpl.c

Just for my curiosity, is this check needed?
When the node joins a DODAG the value is set and never touched again (if I'm not missed something).
I can't find any occurrences where the ->used entry of a DODAG is set to 0.

update: I know that this value is initialized with 0 but maybe we can find a way to rip this member entry

Currently we do not really support a proper way of leaving a dodag. But this will change with subsequent PRs. The idea of this check is to ignore all dodags, which are stored in memory (as left-overs) and only handle the active ones.

BytesGalore · 2015-04-07T07:56:29Z

From the code side it looks good, and works for at least one DODAG (I assume it will also work for multiple DODAGS) 👍, so ACK from my side

OlegHahm · 2015-04-09T22:06:30Z

sys/net/routing/rpl/rpl.c

You could change the uint8_t to unsigned int while you're at it.

cgundogan · 2015-04-13T16:17:27Z

rebased and addressed @OlegHahm's comment

OlegHahm · 2015-04-13T16:39:41Z

sys/net/routing/rpl/rpl.c

if ((my_dodag->used) && (my_dodag->my_preferred_parent != NULL)) {

saves a level of indentation.

cgundogan · 2015-04-13T16:50:12Z

addressed @OlegHahm's comment and combined both if-statements.
I also took the liberty of removing the meaningless comment "/* Parent is NULL for root too */"

OlegHahm · 2015-04-13T16:56:45Z

ACK. Please squash.

cgundogan · 2015-04-13T17:00:15Z

squashed

BytesGalore · 2015-04-13T17:07:06Z

My ACK holds, when travis is happy merge at will

cgundogan · 2015-04-14T09:11:30Z

travis is happy => GO

…odags rpl: update routing table information for all dodags

cgundogan added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer labels Mar 16, 2015

cgundogan assigned OlegHahm Mar 16, 2015

cgundogan added Area: network Area: Networking and removed Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer labels Mar 16, 2015

cgundogan force-pushed the rpl_update_rt_table_for_all_dodags branch from 88f760a to 541352a Compare March 17, 2015 10:41

BytesGalore mentioned this pull request Mar 17, 2015

RPL related issue list #2493

Closed

21 tasks

OlegHahm added the State: waiting for other PR State: The PR requires another PR to be merged first label Mar 18, 2015

cgundogan force-pushed the rpl_update_rt_table_for_all_dodags branch from 541352a to 4f213f6 Compare March 19, 2015 10:46

OlegHahm removed the State: waiting for other PR State: The PR requires another PR to be merged first label Mar 19, 2015

cgundogan force-pushed the rpl_update_rt_table_for_all_dodags branch from 4f213f6 to dbe86b7 Compare March 19, 2015 18:02

BytesGalore reviewed Mar 30, 2015
View reviewed changes

cgundogan force-pushed the rpl_update_rt_table_for_all_dodags branch from dbe86b7 to 95a28f9 Compare March 31, 2015 08:13

Lotterleben force-pushed the master branch from 1d9f189 to d4e068b Compare March 31, 2015 09:52

OlegHahm force-pushed the master branch from d4e068b to 45554bf Compare March 31, 2015 10:04

BytesGalore mentioned this pull request Mar 31, 2015

rpl: remove get_my_dodag dependency by passing the dodag as parameter #2653

Merged

OlegHahm force-pushed the master branch 2 times, most recently from 9f184dd to 45554bf Compare March 31, 2015 13:01

BytesGalore reviewed Apr 7, 2015
View reviewed changes

OlegHahm reviewed Apr 9, 2015
View reviewed changes

sys/net/routing/rpl/rpl.c Outdated

Copy link
Copy Markdown

Member

OlegHahm Apr 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could change the uint8_t to unsigned int while you're at it.

cgundogan force-pushed the rpl_update_rt_table_for_all_dodags branch from 95a28f9 to ee1dd43 Compare April 13, 2015 16:15

OlegHahm added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Apr 13, 2015

OlegHahm reviewed Apr 13, 2015
View reviewed changes

cgundogan force-pushed the rpl_update_rt_table_for_all_dodags branch from 26c0272 to 5557778 Compare April 13, 2015 16:47

rpl: update routing table information for all dodags

d27cd45

cgundogan force-pushed the rpl_update_rt_table_for_all_dodags branch from 5557778 to d27cd45 Compare April 13, 2015 16:59

cgundogan removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Apr 13, 2015

cgundogan added a commit that referenced this pull request Apr 14, 2015

Merge pull request #2607 from cgundogan/rpl_update_rt_table_for_all_d…

ac5e9af

…odags rpl: update routing table information for all dodags

cgundogan merged commit ac5e9af into RIOT-OS:master Apr 14, 2015

cgundogan deleted the rpl_update_rt_table_for_all_dodags branch April 14, 2015 09:11

cgundogan mentioned this pull request Apr 14, 2015

routing/rpl: adjusted RPL to use the FIB #2765

Closed

OlegHahm modified the milestone: Release 2015.06 Apr 29, 2015

Conversation

cgundogan commented Mar 16, 2015

Uh oh!

cgundogan commented Mar 19, 2015

Uh oh!

OlegHahm commented Mar 19, 2015

Uh oh!

cgundogan commented Mar 19, 2015

Uh oh!

OlegHahm commented Mar 19, 2015

Uh oh!

cgundogan commented Mar 19, 2015

Uh oh!

cgundogan commented Mar 19, 2015

Uh oh!

cgundogan commented Mar 24, 2015

Uh oh!

BytesGalore Mar 30, 2015

Choose a reason for hiding this comment

Uh oh!

cgundogan Mar 31, 2015

Choose a reason for hiding this comment

Uh oh!

cgundogan commented Mar 31, 2015

Uh oh!

cgundogan commented Apr 7, 2015

Uh oh!

BytesGalore Apr 7, 2015

Choose a reason for hiding this comment

Uh oh!

cgundogan Apr 7, 2015

Choose a reason for hiding this comment

Uh oh!

BytesGalore commented Apr 7, 2015

Uh oh!

OlegHahm Apr 9, 2015

Choose a reason for hiding this comment

Uh oh!

cgundogan commented Apr 13, 2015

Uh oh!

OlegHahm Apr 13, 2015

Choose a reason for hiding this comment

Uh oh!

cgundogan commented Apr 13, 2015

Uh oh!

OlegHahm commented Apr 13, 2015

Uh oh!

cgundogan commented Apr 13, 2015

Uh oh!

BytesGalore commented Apr 13, 2015

Uh oh!

cgundogan commented Apr 14, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants