Skip to content

net: initial import of ethertypes and the ethernet header#2579

Merged
miri64 merged 2 commits intoRIOT-OS:masterfrom
miri64:net/feat/initial-ethertype-ethernet
Mar 12, 2015
Merged

net: initial import of ethertypes and the ethernet header#2579
miri64 merged 2 commits intoRIOT-OS:masterfrom
miri64:net/feat/initial-ethertype-ethernet

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Mar 11, 2015

Does what it says on the tin ;-)

@miri64 miri64 added Area: network Area: Networking Type: new feature The issue requests / The PR implemements a new feature for RIOT NSTF labels Mar 11, 2015
OlegHahm
OlegHahm reviewed Mar 11, 2015
View reviewed changes
sys/include/net/ng_ethertype.h Outdated
Copy link
Copy Markdown
Member

@OlegHahm OlegHahm Mar 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

protocol version 4

Copy link
Copy Markdown
Member Author

@miri64 miri64 Mar 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@miri64 miri64 force-pushed the net/feat/initial-ethertype-ethernet branch from e3bebd8 to e7c3fdd Compare March 11, 2015 17:36
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Mar 11, 2015

I also added some frame length definitions ;-)

@miri64 miri64 mentioned this pull request Mar 11, 2015
Closed
1 task
@cgundogan
Copy link
Copy Markdown
Member

cgundogan commented Mar 12, 2015

Looks good to me. Travis is complaining about doxygen warnings, however.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Mar 12, 2015

Fixed. :-)

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Mar 12, 2015

+ added a reserved ethertype ;-)

@miri64 miri64 mentioned this pull request Mar 12, 2015
Merged
@miri64 miri64 added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Mar 12, 2015
@cgundogan
Copy link
Copy Markdown
Member

cgundogan commented Mar 12, 2015

ACK still holds. Squash needed. When travis verifies then GO

@miri64 miri64 force-pushed the net/feat/initial-ethertype-ethernet branch from a24d982 to 396a56d Compare March 12, 2015 10:27
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Mar 12, 2015

Squashed.

@miri64 miri64 force-pushed the net/feat/initial-ethertype-ethernet branch from 396a56d to 4364493 Compare March 12, 2015 10:31
@miri64 miri64 removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Mar 12, 2015
miri64 added a commit that referenced this pull request Mar 12, 2015
@miri64
Merge pull request #2579 from authmillenon/net/feat/initial-ethertype…
d67d983 
…-ethernet

net: initial import of ethertypes and the ethernet header
@miri64 miri64 merged commit d67d983 into RIOT-OS:master Mar 12, 2015
@miri64 miri64 deleted the net/feat/initial-ethertype-ethernet branch March 12, 2015 12:01
@OlegHahm OlegHahm modified the milestone: Release 2015.06 Apr 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cgundogan cgundogan

Labels

Area: network Area: Networking Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Milestone

Release 2015.09

Development

Successfully merging this pull request may close these issues.

3 participants

@miri64 @cgundogan @OlegHahm