net: add ng version of the netdev interface#2398
net: add ng version of the netdev interface#2398haukepetersen merged 1 commit intoRIOT-OS:masterfrom
Conversation
sys/include/net/ng_netdev.h
Outdated
There was a problem hiding this comment.
Is there a reason not to typedef this?
There was a problem hiding this comment.
if you look some lines up in the code, you see it is typedefed... The forward declaration is needed as the type is used in ng_netdev_driver_t...
|
fixed some doxygen |
There was a problem hiding this comment.
excuse my ignorance, but where does this number came from?
There was a problem hiding this comment.
nowhere. Just picked some number...
There was a problem hiding this comment.
I c.. from the brainware pseudo-random number generator 
There was a problem hiding this comment.
Please surround by ifndef
There was a problem hiding this comment.
really? I feel that at some point we start to surround every single define with '#ifndef'... I would rather leave at is and adjust the chosen value if needed -> wasn't there some discussion for system wide message numbers anyway?
There was a problem hiding this comment.
Yes, this is the preliminary outcome.
|
renamed struct as suggested by @cgundogan |
|
I don't see that the msg type discussion is PR relevant. ACK, please squash. |
8a4a079 to
7149677
Compare
|
squashed and rebased - lets wait for Travis... |
|
kicked Travis |
net: add ng version of the netdev interface
|
Travis is happy, and go. |
No description provided.