Skip to content

drivers/hdc1000: Acquire exclusive access to I2C bus and minor bug fixes#2354

Merged
PeterKietzmann merged 1 commit intoRIOT-OS:masterfrom
jfischer-no:ts@hdc1000
Jan 28, 2015
Merged

drivers/hdc1000: Acquire exclusive access to I2C bus and minor bug fixes#2354
PeterKietzmann merged 1 commit intoRIOT-OS:masterfrom
jfischer-no:ts@hdc1000

Conversation

@jfischer-no
Copy link
Copy Markdown
Contributor

@jfischer-no jfischer-no commented Jan 26, 2015

This PR adds exclusive access to I2C bus and minor bug fixes for HDC1000 driver:

  • fix doxygen warnings
  • change default address
  • remove redundant vtimer_usleep call

@jfischer-no jfischer-no added Area: drivers Area: Device drivers Type: new feature The issue requests / The PR implemements a new feature for RIOT Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation and removed Type: new feature The issue requests / The PR implemements a new feature for RIOT labels Jan 26, 2015
jnohlgard
jnohlgard reviewed Jan 26, 2015
View reviewed changes
drivers/hdc1000/hdc1000.c Outdated
Copy link
Copy Markdown
Member

@jnohlgard jnohlgard Jan 26, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can merge this i2c_release and the one on L78 by inserting i2c_release(dev->i2c); to between L75,L76

Copy link
Copy Markdown
Member

@thomaseichinger thomaseichinger Jan 26, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support this.

@haukepetersen haukepetersen mentioned this pull request Jan 27, 2015
Closed
44 tasks
@PeterKietzmann
Copy link
Copy Markdown
Member

PeterKietzmann commented Jan 27, 2015

@jfischer-phytec-iot just IF you are planning to do more work on this "making bus drivers thread safe", please assign yourself in #2314 so our work won't collide... Cheers!

@jfischer-no jfischer-no added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Jan 27, 2015
@PeterKietzmann PeterKietzmann added the Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties label Jan 27, 2015
PeterKietzmann
PeterKietzmann reviewed Jan 27, 2015
View reviewed changes
drivers/hdc1000/hdc1000.c Outdated
Copy link
Copy Markdown
Member

@PeterKietzmann PeterKietzmann Jan 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why you aqcuired i2c before generating reg here while you didn't do so for example in line 130?

Copy link
Copy Markdown
Contributor Author

@jfischer-no jfischer-no Jan 28, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, corrected and squashed

@PeterKietzmann
Copy link
Copy Markdown
Member

PeterKietzmann commented Jan 27, 2015

@jfischer-phytec-iot if my above comment is reasoned I would ACK this. Tested and worked

@PeterKietzmann
Copy link
Copy Markdown
Member

PeterKietzmann commented Jan 27, 2015

PS: and please squash

@PeterKietzmann
Copy link
Copy Markdown
Member

PeterKietzmann commented Jan 28, 2015

ACK but waiting for Travis

@jfischer-no jfischer-no removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Jan 28, 2015
@PeterKietzmann
Copy link
Copy Markdown
Member

PeterKietzmann commented Jan 28, 2015

Travis failed for a unrelated reasons and because of the "Needs Squashing" label which you removed. Let's merge

PeterKietzmann added a commit that referenced this pull request Jan 28, 2015
@PeterKietzmann
Merge pull request #2354 from jfischer-phytec-iot/ts@hdc1000
13e9f16 
drivers/hdc1000: Acquire exclusive access to I2C bus and  minor bug fixes
@PeterKietzmann PeterKietzmann merged commit 13e9f16 into RIOT-OS:master Jan 28, 2015
@jfischer-no jfischer-no deleted the ts@hdc1000 branch January 29, 2015 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@thomaseichinger thomaseichinger

Labels

Area: drivers Area: Device drivers Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jfischer-no @PeterKietzmann @thomaseichinger @jnohlgard