Skip to content

sixlowpan: rename to sixlowpan_legacy#1967

Closed
miri64 wants to merge 1 commit intoRIOT-OS:masterfrom
miri64:sixlowpan_legacy
Closed

sixlowpan: rename to sixlowpan_legacy#1967
miri64 wants to merge 1 commit intoRIOT-OS:masterfrom
miri64:sixlowpan_legacy

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Nov 7, 2014

Since #1680 turns out to become quite a nightmare review-wise, I decided to split and clean it up a little. First point on the agenda is to make it more or less independent from the old 6LoWPAN module. For this I renamed the old module to sixlowpan_legacy and I will remove the move commit from #1680. Though I recycled lot of the original code in #1680, it is not what it used to be, so the changes wouldn't be that visible anyways.

@miri64 miri64 added Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. Impact: major The PR changes a significant part of the code base. It should be reviewed carefully labels Nov 7, 2014
@miri64 miri64 added this to the Release NEXT MAJOR milestone Nov 7, 2014
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Nov 7, 2014

Travis fails due to cppcheck and externc.sh. Must I really do this for this?

@miri64 miri64 mentioned this pull request Nov 7, 2014
Closed
@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Nov 7, 2014

Travis fails due to cppcheck and externc.sh. Must I really do this for this?

I'd say no.

For this PR in general: I'm a bit reluctant to rename sixlowpan to sixlowpan_legacy without including a proper sixlowpan into RIOT master.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Nov 7, 2014

That's what #1680 is for ;-)

@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Nov 7, 2014

So, this PR is mainly split for review and intended to be merged along with #1680? Is there a need for sixlowpan_legacy after #1680 is merged?

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Nov 7, 2014

For older boards maybe.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Nov 10, 2014

Rebased

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Nov 11, 2014

Rebased

@miri64 miri64 force-pushed the sixlowpan_legacy branch 2 times, most recently from dc3e044 to 52d7a85 Compare November 14, 2014 07:16
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Nov 14, 2014

Rebased

miri64 added a commit to miri64/RIOT that referenced this pull request Nov 14, 2014
@miri64
Merge branch 'sixlowpan_legacy' (RIOT-OS#1967) into 6lowpan-fix-major
43d7bc5
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Nov 20, 2014

Rebased to master

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Nov 20, 2014

Rebased

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Dec 3, 2014

Had do redo the whole thing due to heavy changes in #1404 and #1767.

@LudwigKnuepfer
Copy link
Copy Markdown
Member

LudwigKnuepfer commented Dec 5, 2014

needs rebase

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Dec 5, 2014

sigh not today… this is just to complex again -.-

@miri64 miri64 modified the milestones: Release NEXT MAJOR, Release 2014.12 Dec 6, 2014
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Jan 13, 2015

Rebased to master

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Jan 15, 2015

Will rebase next either after review of #1680 or when heavy changes to rpl stop.

@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Jan 15, 2015

I think we should not rename this before the new network stack is ready anyways. In the best case we don't need this PR and can just remove the old implementation completely.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Jan 15, 2015

Yes of course: the goal of this PR is more to get the old implementation out of the way to give me breathing room for the new implementation, than a thing I actually want to do ;-)

@OlegHahm OlegHahm modified the milestones: Release NEXT MAJOR, Network Stack Task Force Feb 6, 2015
@OlegHahm OlegHahm added NSTF and removed NSTF labels Feb 6, 2015
@miri64 miri64 modified the milestone: Network Stack Task Force Feb 8, 2015
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Feb 8, 2015

Abandoned. New implementation will get a ng_ prefix (see #2278)

@miri64 miri64 closed this Feb 8, 2015
@miri64 miri64 deleted the sixlowpan_legacy branch February 8, 2015 14:06
@miri64 miri64 added State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet and removed State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet labels Feb 8, 2015
@miri64 miri64 added the Area: network Area: Networking label Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@OlegHahm OlegHahm

Labels

Area: network Area: Networking Impact: major The PR changes a significant part of the code base. It should be reviewed carefully Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@miri64 @OlegHahm @LudwigKnuepfer