doc: do not rebuild riot.css#19665
Merged
bors[bot] merged 1 commit intoRIOT-OS:masterfrom May 25, 2023
Merged
Conversation
- simplify the makefile
- changing behavior depending on lessc being installed is
surprising and makes the Makefile less readable
- failing with `make: lessc: No such file or directory` is helpful,
but `make: No rule to make target 'src/css/riot.css'` is not
clearly indicating that `lessc` was not found
- don't rebuild `riot.css` when generating HTML output
- anyone touching the less file will have to manually call
`make src/css/riot.css -C doc/doxygen`
- this happens so rarely that implementing a convenient mechanism
is not worth the trouble
Fixes RIOT-OS#8122
benpicco
approved these changes
May 25, 2023
Member
Author
|
bors merge |
Contributor
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
Member
Author
|
Thx :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
make: lessc: No such file or directoryis helpful, butmake: No rule to make target 'src/css/riot.css'is not clearly indicating thatlesscwas not foundriot.csswhen generating HTML outputmake src/css/riot.css -C doc/doxygenTesting procedure
make docshould no longer regenerateriot.css, regardless of whetherlesscis available or not.Issues/PRs references
Fixes #8122