Skip to content

Commit cfee27c

Browse files
committed
doc: do not rebuild riot.css
- simplify the makefile - changing behavior depending on lessc being installed is surprising and makes the Makefile less readable - failing with `make: lessc: No such file or directory` is helpful, but `make: No rule to make target 'src/css/riot.css'` is not clearly indicating that `lessc` was not found - don't rebuild `riot.css` when generating HTML output - anyone touching the less file will have to manually call `make src/css/riot.css -C doc/doxygen` - this happens so rarely that implementing a convenient mechanism is not worth the trouble Fixes #8122
1 parent 7d16a1b commit cfee27c

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

doc/doxygen/Makefile

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ export STRIP_FROM_INC_PATH_LIST=$(shell \
77

88
# use lessc (http://lesscss.org/#using-less) for compiling CSS
99
# It can also be installed in ubuntu with the `node-less` package
10-
LESSC ?= $(shell command -v lessc 2>/dev/null)
10+
LESSC ?= lessc
1111

1212
DOCUMENTATION_FORMAT ?= html
1313

@@ -16,7 +16,7 @@ doc: $(DOCUMENTATION_FORMAT)
1616

1717
# by marking html as phony we force make to re-run Doxygen even if the directory exists.
1818
.PHONY: html
19-
html: src/css/riot.css src/changelog.md
19+
html: src/changelog.md
2020
( cat riot.doxyfile ; echo "GENERATE_HTML = yes" ) | doxygen -
2121

2222
.PHONY: check
@@ -27,14 +27,12 @@ check: src/changelog.md
2727
man: src/changelog.md
2828
( cat riot.doxyfile ; echo "GENERATE_MAN = yes" ) | doxygen -
2929

30-
ifneq (,$(LESSC))
3130
src/css/riot.css: src/css/riot.less src/css/variables.less
3231
@$(LESSC) $< $@
3332

3433
src/css/variables.less: src/config.json
3534
@grep "^\s*\"@" $< | sed -e 's/^\s*"//g' -e 's/":\s*"/: /g' \
3635
-e 's/",\?$$/;/g' -e 's/\\"/"/g' > $@
37-
endif
3836

3937
src/changelog.md: src/changelog.md.tmp ../../release-notes.txt
4038
@./generate-changelog.py $+ $@

0 commit comments

Comments
 (0)