makefiles/tools/serial.inc.mk: Handle new miniterm versions#19444
Merged
bors[bot] merged 1 commit intoRIOT-OS:masterfrom Apr 4, 2023
Merged
makefiles/tools/serial.inc.mk: Handle new miniterm versions#19444bors[bot] merged 1 commit intoRIOT-OS:masterfrom
bors[bot] merged 1 commit intoRIOT-OS:masterfrom
Conversation
maribu
reviewed
Apr 3, 2023
5dae1b3 to
83bffec
Compare
maribu
reviewed
Apr 4, 2023
While testing examples/micropython I notice that the default of miniterm.py is actually miniterm. To simplify user setups, this checks for miniterm.py first then falls back to miniterm.
83bffec to
6d72903
Compare
maribu
approved these changes
Apr 4, 2023
Member
|
bors merge |
Contributor
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Apr 4, 2023
19451: makefiles/tools/serial.inc.mk: Handle new miniterm versions [backport 2023.01] r=maribu a=MrKevinWeiss # Backport of #19444 ### Contribution description While testing examples/micropython I notice that the default of miniterm.py is actually miniterm. To simplify user setups, this checks for miniterm.py first then falls back to miniterm. ### Testing procedure Take any board with any newish version of Ubuntu and run ``` make -C flash test examples/micropython ``` If you have `miniterm.py` in `PATH` or if it is `miniterm` both should work. ### Issues/PRs references Co-authored-by: MrKevinWeiss <weiss.kevin604@gmail.com>
Contributor
Author
|
Thanks |
bors bot
added a commit
that referenced
this pull request
Apr 21, 2023
19489: makefiles/tools/serial.inc.mk: Handle new miniterm versions [backport 2023.04] r=maribu a=MrKevinWeiss # Backport of #19444 ### Contribution description While testing examples/micropython I notice that the default of miniterm.py is actually miniterm. To simplify user setups, this checks for miniterm.py first then falls back to miniterm. ### Testing procedure Take any board with any newish version of Ubuntu and run ``` make -C flash test examples/micropython ``` If you have `miniterm.py` in `PATH` or if it is `miniterm` both should work. ### Issues/PRs references Co-authored-by: MrKevinWeiss <weiss.kevin604@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
While testing examples/micropython I notice that the default of miniterm.py is actually miniterm. To simplify user setups, this checks for miniterm.py first then falls back to miniterm.
Testing procedure
Take any board with any newish version of Ubuntu and run
If you have
miniterm.pyinPATHor if it isminitermboth should work.Issues/PRs references