sys/event: add periodic timeout event #16507
Merged
kaspar030 merged 3 commits intoRIOT-OS:masterfrom Jun 8, 2021
Merged
Conversation
Contributor
|
please rebase! |
31604d6 to
1f4d5f7
Compare
kaspar030
requested changes
Jun 1, 2021
sys/include/event/timeout.h
Outdated
| */ | ||
| void event_timeout_clear(event_timeout_t *event_timeout); | ||
|
|
||
| #if IS_USED(MODULE_EVENT_PERIODIC_TIMEOUT) |
Contributor
There was a problem hiding this comment.
this should have || doxygen.
(I think I missed that for event_timeout_ztimer)
Contributor
Author
|
@kaspar030 may I squash? |
kaspar030
reviewed
Jun 1, 2021
33776f1 to
86b32e0
Compare
Contributor
|
I think "event_periodic" would suffice as a name (drop the "timeout"). What do you think? |
86b32e0 to
b0396ee
Compare
Contributor
Author
dropped. |
Contributor
Author
|
Unrelated test failures |
Contributor
Author
|
Unrelated test failure:
Will re-run without tests :) |
kaspar030
approved these changes
Jun 8, 2021
Contributor
kaspar030
left a comment
There was a problem hiding this comment.
ACK.
Code looks fine. Tested on nrf52840dk and native.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR adds a periodic timeout event using
ztimer. Useful to scheduler a task that should be periodically executed, e.g.: reading some sensor.Testing procedure
make -C tests/event_timeout_ztimerIssues/PRs references
depend on #16505