Skip to content

sys/event/timeout: add option to use ztimer as backend#16505

Merged
kaspar030 merged 1 commit intoRIOT-OS:masterfrom
fjmolinas:pr_event_timeout_ztimer
Jun 1, 2021
Merged

sys/event/timeout: add option to use ztimer as backend#16505
kaspar030 merged 1 commit intoRIOT-OS:masterfrom
fjmolinas:pr_event_timeout_ztimer

Conversation

@fjmolinas
Copy link
Copy Markdown
Contributor

@fjmolinas fjmolinas commented May 27, 2021 •
edited
Loading

Contribution description

This PR adds an option to use ztimer as the backend for an event/timeout. To keep the API compatible I added a ztimer_clock_t field to the event_timeout_t type. But this could also be passed in the function signature and maybe have static inlines to implement the current API.

Testing procedure

  • USEMODULE+=event_timeout_ztimer make -C flash teset

TODO: add a individual test.

@fjmolinas fjmolinas added the Area: timers Area: timer subsystems label May 27, 2021
@fjmolinas fjmolinas requested review from kaspar030 and kfessel May 27, 2021 20:36
@github-actions github-actions bot added Area: build system Area: Build system Area: sys Area: System Area: tests Area: tests and testing framework and removed Area: timers Area: timer subsystems labels May 27, 2021
@fjmolinas fjmolinas mentioned this pull request May 28, 2021
Merged
@fjmolinas fjmolinas added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 1, 2021
@fjmolinas
Copy link
Copy Markdown
Contributor Author

fjmolinas commented Jun 1, 2021

I added an individual test in #16507

kaspar030
kaspar030 approved these changes Jun 1, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

Tested on native using tests/events.
Code looks fine.

@kaspar030 kaspar030 merged commit fde0bb7 into RIOT-OS:master Jun 1, 2021
@MrKevinWeiss MrKevinWeiss added Process: release backport Integration Process: The PR is a release backport of a change previously provided to master and removed Process: release backport Integration Process: The PR is a release backport of a change previously provided to master labels Jul 15, 2021
@MrKevinWeiss MrKevinWeiss added this to the Release 2021.07 milestone Jul 15, 2021
@fjmolinas fjmolinas deleted the pr_event_timeout_ztimer branch July 30, 2021 11:28
@haukepetersen haukepetersen mentioned this pull request Sep 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaspar030 kaspar030 kaspar030 approved these changes

@kfessel kfessel Awaiting requested review from kfessel

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@smlng smlng Awaiting requested review from smlng

Assignees

No one assigned

Labels

Area: build system Area: Build system Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR

Projects

None yet

Milestone

Release 2021.07

Development

Successfully merging this pull request may close these issues.

3 participants

@fjmolinas @kaspar030 @MrKevinWeiss