Skip to content

tests/kconfig_features: remove boards whitelist#14541

Merged
aabadie merged 1 commit intoRIOT-OS:masterfrom
aabadie:pr/tests/kconfig_features_remove_whitelist
Jul 17, 2020
Merged

tests/kconfig_features: remove boards whitelist#14541
aabadie merged 1 commit intoRIOT-OS:masterfrom
aabadie:pr/tests/kconfig_features_remove_whitelist

Conversation

@aabadie
Copy link
Copy Markdown
Contributor

@aabadie aabadie commented Jul 17, 2020 •
edited
Loading

Contribution description

This PR removes the boards whitelist defined in tests/kconfig_features. Since #14148 is almost done (only samd21 based boards remains to be merged), there's no need to maintain this list. This will also enforce new board supports to add Kconfig.

Testing procedure

A green Murdock

Issues/PRs references

Wait for #14189 and fixes #14148

@aabadie aabadie added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: tests Area: tests and testing framework State: waiting for other PR State: The PR requires another PR to be merged first CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: Kconfig Area: Kconfig integration labels Jul 17, 2020
@aabadie
Copy link
Copy Markdown
Contributor Author

aabadie commented Jul 17, 2020

I'm opening it before #14189 is merged, just to make sure it will fail if a board doesn't provide Kconfig.

@aabadie
tests/kconfig_features: remove board whitelist
cec5c8e 
Now that all boards/cpus are migrated to Kconfig, we don't need this list anymore and it will enforce new boards to be adapted as well
@aabadie aabadie force-pushed the pr/tests/kconfig_features_remove_whitelist branch from bb8e7a0 to cec5c8e Compare July 17, 2020 07:43
@aabadie
Copy link
Copy Markdown
Contributor Author

aabadie commented Jul 17, 2020 •
edited
Loading

rebased, Murdock should succeed now.

@aabadie aabadie added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed State: waiting for other PR State: The PR requires another PR to be merged first CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jul 17, 2020
leandrolanzieri
leandrolanzieri approved these changes Jul 17, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK! Let's see what the CI says

@leandrolanzieri leandrolanzieri added this to the Release 2020.10 milestone Jul 17, 2020
@leandrolanzieri leandrolanzieri added the Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines label Jul 17, 2020
@aabadie aabadie merged commit 5801d60 into RIOT-OS:master Jul 17, 2020
@aabadie aabadie deleted the pr/tests/kconfig_features_remove_whitelist branch July 17, 2020 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@smlng smlng Awaiting requested review from smlng

Assignees

No one assigned

Labels

Area: Kconfig Area: Kconfig integration Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2020.10

Development

Successfully merging this pull request may close these issues.

Tracker: Kconfig: Model features provided by CPU and Board

2 participants

@aabadie @leandrolanzieri