Skip to content

boards/samd21-based: Model features in Kconfig#14189

Merged
aabadie merged 33 commits intoRIOT-OS:masterfrom
jia200x:pr/boards/samd21
Jul 17, 2020
Merged

boards/samd21-based: Model features in Kconfig#14189
aabadie merged 33 commits intoRIOT-OS:masterfrom
jia200x:pr/boards/samd21

Conversation

@jia200x
Copy link
Copy Markdown
Member

@jia200x jia200x commented Jun 2, 2020 •
edited
Loading

Contribution description

This PR models the features for samd21 based boards and adds them to the Kconfig_features test whitelist.

Testing procedure

It should be enough to check that the Kconfig_features test works for all these boards (this means the list of provided features is equivalent):

BOARD=arduino-mkr1000 make && \
BOARD=arduino-mkrfox1200 make && \
BOARD=arduino-mkrwan1300 make && \
BOARD=arduino-mkrzero make && \
BOARD=arduino-zero make && \
BOARD=feather-m0 make && \
BOARD=hamilton make && \
BOARD=samd21-xpro make && \
BOARD=samr21-xpro make && \
BOARD=sensebox_samd21 make && \
BOARD=serpente make && \
BOARD=sodaq-autonomo make && \
BOARD=sodaq-explorer make && \
BOARD=sodaq-one make && \
BOARD=sodaq-sara-aff &&\
echo "OK"

Issues/PRs references

Depends on #13404
#14148

@jia200x jia200x added Type: new feature The issue requests / The PR implemements a new feature for RIOT TF: Config Marks issues and PRs related to the work of the Configuration Task Force Area: Kconfig Area: Kconfig integration labels Jun 2, 2020
leandrolanzieri
leandrolanzieri reviewed Jun 2, 2020
View reviewed changes
@jia200x jia200x force-pushed the pr/boards/samd21 branch from 8b5b747 to a9ccca9 Compare June 2, 2020 14:03
@jia200x jia200x changed the title boards/samd21: Model features in Kconfig boards/samd21-based: Model features in Kconfig Jun 2, 2020
@jia200x jia200x mentioned this pull request Jun 2, 2020
Closed
@leandrolanzieri leandrolanzieri added the State: waiting for other PR State: The PR requires another PR to be merged first label Jun 2, 2020
@leandrolanzieri
Copy link
Copy Markdown
Contributor

leandrolanzieri commented Jun 3, 2020

This needs rebasing

@jia200x jia200x force-pushed the pr/boards/samd21 branch from 03b8d20 to 56018ba Compare June 3, 2020 08:30
@leandrolanzieri leandrolanzieri added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed State: waiting for other PR State: The PR requires another PR to be merged first CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 3, 2020
leandrolanzieri
leandrolanzieri reviewed Jun 4, 2020
View reviewed changes
@leandrolanzieri leandrolanzieri removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 4, 2020
@leandrolanzieri
Copy link
Copy Markdown
Contributor

leandrolanzieri commented Jun 17, 2020

This needs rebasing and adapting to the new classification

@leandrolanzieri
Copy link
Copy Markdown
Contributor

leandrolanzieri commented Jun 24, 2020

@jia200x ping!

@leandrolanzieri
Copy link
Copy Markdown
Contributor

leandrolanzieri commented Jul 9, 2020

@jia200x will not be having time so he said it's ok to take over. I rebased and applied some fixes.

@fjmolinas maybe you can take a look?

@leandrolanzieri leandrolanzieri self-assigned this Jul 9, 2020
aabadie
aabadie requested changes Jul 16, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one minor nit. Please rebase!

@leandrolanzieri leandrolanzieri force-pushed the pr/boards/samd21 branch 2 times, most recently from be5d3a6 to 05a5f3c Compare July 16, 2020 15:06
jia200x added 16 commits July 17, 2020 08:44
@jia200x @aabadie
boards/arduino-zero: Add board specific Kconfig symbols
c4aa9fb
@jia200x @aabadie
tests/Kconfig: add arduino-zero to whitelist
878a201
@jia200x @aabadie
boards/feather-m0: Add board specific Kconfig symbols
f5c0e4a
@jia200x @aabadie
tests/Kconfig: add feather-m0 to whitelist
a005d68
@jia200x @aabadie
boards/hamilton: Add board specific Kconfig symbols
4c73190
@jia200x @aabadie
tests/Kconfig: add hamilton to whitelist
65d0bb5
@jia200x @aabadie
boards/samd21-xpro: Add board specific Kconfig symbols
b475d37
@jia200x @aabadie
tests/Kconfig: add samd21-xpro to whitelist
7e60c66
@jia200x @aabadie
boards/sensebox_samd21: Add board specific Kconfig symbols
853f06e
@jia200x @aabadie
tests/Kconfig: add sensebox_samd21 to whitelist
4fa465b
@jia200x @aabadie
boards/serpente: Add board specific Kconfig symbols
d95e2a1
@jia200x @aabadie
tests/Kconfig: add serpente to whitelist
b39b881
@jia200x @aabadie
boards/sodaq-autonomo: Add board specific Kconfig symbols
6139e63
@jia200x @aabadie
tests/Kconfig: add sodaq-autonomo to whitelist
2776e56
@jia200x @aabadie
boards/sodaq-explorer: Add board specific Kconfig symbols
bd41ccc
@jia200x @aabadie
tests/Kconfig: add sodaq-explorer to whitelist
f7fcdab
@leandrolanzieri
Copy link
Copy Markdown
Contributor

leandrolanzieri commented Jul 17, 2020

Rebased once more :)

@aabadie aabadie force-pushed the pr/boards/samd21 branch from 47be8b1 to 1abe732 Compare July 17, 2020 06:48
@aabadie aabadie added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jul 17, 2020
@aabadie
Copy link
Copy Markdown
Contributor

aabadie commented Jul 17, 2020

Rebased once more :)

Same here, I was also on it :)

aabadie
aabadie approved these changes Jul 17, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, ACK!

@aabadie aabadie merged commit 00f28a3 into RIOT-OS:master Jul 17, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.10 milestone Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri left review comments

@aabadie aabadie aabadie approved these changes

@cgundogan cgundogan Awaiting requested review from cgundogan

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@smlng smlng Awaiting requested review from smlng

Assignees

@leandrolanzieri leandrolanzieri

Labels

Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR TF: Config Marks issues and PRs related to the work of the Configuration Task Force Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Milestone

Release 2020.10

Development

Successfully merging this pull request may close these issues.

3 participants

@jia200x @leandrolanzieri @aabadie