drivers/ bmx055 : Expose Configurations to Kconfig#13998
Merged
leandrolanzieri merged 2 commits intoRIOT-OS:masterfrom May 4, 2020
Merged
drivers/ bmx055 : Expose Configurations to Kconfig#13998leandrolanzieri merged 2 commits intoRIOT-OS:masterfrom
leandrolanzieri merged 2 commits intoRIOT-OS:masterfrom
Conversation
71 tasks
Contributor
|
Please rebase |
Add CONFIG_ prefix to compile configurations
Member
Author
Done. |
Expose configurations to Kconfig
leandrolanzieri
approved these changes
May 4, 2020
Contributor
leandrolanzieri
left a comment
There was a problem hiding this comment.
Kconfig defaults yield the same as the current macros. Changes in menuconfig reflect in the configuration macros. ACK.
Member
Author
Thnak you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR exposes compile configurations in BMX055 Sensor Device driver to Kconfig.
Testing procedure
The build works fine.
Header was introduced in tests/driver_bmx055/main.c for testing.
#include "bmx055.h"New macro was introduced in tests/driver_bmx055/main.c for testing.
Firmware was uploaded to FIT IoT Lab test bed.
Default State:
Firmware Output
[auto_init_saul] error initializing bmx055 #0
main(): This is RIOT! (Version: 2020.07-devel-312-g404ed-Kconfig_bmx055_tests)
CONFIG_BMX055_MAG_ADDR_DEFAULT=(0x10U)
CONFIG_BMX055_ACC_ADDR_DEFAULT=(0x18U)
CONFIG_BMX055_GYRO_ADDR_DEFAULT=(0x68U)
Test application for bmx055 module
Dev: LED(orange) Type: ACT_SWITCH
Data: 0
Dev: Button(SW0) Type: SENSE_BTN
Data: 0
Usage with CFLAGS
/tests/driver_bmx055/Makefile
Firmware Output
[auto_init_saul] error initializing bmx055 #0
main(): This is RIOT! (Version: 2020.07-devel-312-g404ed-Kconfig_bmx055_tests)
CONFIG_BMX055_MAG_ADDR_DEFAULT=0x11
CONFIG_BMX055_ACC_ADDR_DEFAULT=0x19
CONFIG_BMX055_GYRO_ADDR_DEFAULT=0x69
Test application for bmx055 module
Dev: LED(orange) Type: ACT_SWITCH
Data: 0
Dev: Button(SW0) Type: SENSE_BTN
Data: 0
Usage with Kconfig
/tests/driver_bmx055/
Firmware Output
[auto_init_saul] error initializing bmx055 #0
main(): This is RIOT! (Version: 2020.07-devel-312-g404ed-Kconfig_bmx055_tests)
CONFIG_BMX055_MAG_ADDR_DEFAULT=0x13
CONFIG_BMX055_ACC_ADDR_DEFAULT=0x19
CONFIG_BMX055_GYRO_ADDR_DEFAULT=0x69
Test application for bmx055 module
Dev: LED(orange) Type: ACT_SWITCH
Data: 0
Dev: Button(SW0) Type: SENSE_BTN
Data: 0
Note : The sensor is not available for interfacing hence configurability of macros were only tested.
Issues/PRs references
#12888
@leandrolanzieri Please merge this only after #13981