Skip to content

drivers/Kconfig: Move Actuator and Sensor menus to root file#13981

Merged
jia200x merged 1 commit intoRIOT-OS:masterfrom
leandrolanzieri:pr/drivers/kconfig_move_sensors_actuators
May 4, 2020
Merged

drivers/Kconfig: Move Actuator and Sensor menus to root file#13981
jia200x merged 1 commit intoRIOT-OS:masterfrom
leandrolanzieri:pr/drivers/kconfig_move_sensors_actuators

Conversation

@leandrolanzieri
Copy link
Copy Markdown
Contributor

Contribution description

I just realized that during the exposure of various driver configurations to Kconfig we have been wrongly placing the menus in Kconfig.net file instead of Kconfig. This fixes it.

Testing procedure

  • Run make menuconfig on some application that has driver options (e.g. tests/driver_ads101x), menus and options should still be on the same place.

Issues/PRs references

None

@leandrolanzieri leandrolanzieri added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Area: Kconfig Area: Kconfig integration labels Apr 29, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.07 milestone Apr 29, 2020
@leandrolanzieri
Copy link
Copy Markdown
Contributor Author

@akshaim may want to take a look

@akshaim
Copy link
Copy Markdown
Member

akshaim commented Apr 29, 2020

@akshaim may want to take a look

Just curious here. Wont it be nice to have a separate Kconfig file for sensors similar to network devices ?

@leandrolanzieri
Copy link
Copy Markdown
Contributor Author

Just curious here. Wont it be nice to have a separate Kconfig file for sensors similar to network devices ?

hmm could be, let's leave that to a follow-up

@jia200x
Copy link
Copy Markdown
Member

jia200x commented May 4, 2020

Just tested it and confirm these sub-menus are still in the same place.

Copy link
Copy Markdown
Member

@jia200x jia200x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@jia200x jia200x merged commit d03884d into RIOT-OS:master May 4, 2020
@leandrolanzieri leandrolanzieri deleted the pr/drivers/kconfig_move_sensors_actuators branch May 4, 2020 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants