Skip to content

pkg/nordic_softdevice_ble: Imminent deprecation warning#13334

Merged
miri64 merged 2 commits intoRIOT-OS:masterfrom
chrysn-pull-requests:nordic-softdevice-ipsp-warning
Feb 11, 2020
Merged

pkg/nordic_softdevice_ble: Imminent deprecation warning#13334
miri64 merged 2 commits intoRIOT-OS:masterfrom
chrysn-pull-requests:nordic-softdevice-ipsp-warning

Conversation

@chrysn
Copy link
Copy Markdown
Member

@chrysn chrysn commented Feb 11, 2020

Contribution description

This makes the nRF softdevice docs accessible via doxygen and explains the outdatedness situation.

The goal of this is to bring some form of closure to #11951, whose underlying issue is that the first thing you find when searching for RIOT and Linux IPSP connectivity is that "it works only with kernels up to 4.12" (ie. still didn't solve the ages-old bug there).

Issues/PRs references

This won't technically close #11951, but put it in a state where I'd be comfortable closing it with "won't fix unless someone resumes work on #9473.

Alternatives

  • Fully deprecate that module. Might well be an option, I don't know enough about non-IPSP uses of that module to make assertions there.
  • Finish Feature update n rf5 sdk 15.0.0 #9473. Doesn't seem like anyone is (still) motivated to work on the softdevice now that Nimble works.

This was referenced Feb 11, 2020
Closed
Closed
@chrysn chrysn added Area: doc Area: Documentation Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Feb 11, 2020
miri64
miri64 approved these changes Feb 11, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 11, 2020
@chrysn chrysn added the CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs label Feb 11, 2020
@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Feb 11, 2020
@miri64
Copy link
Copy Markdown
Member

miri64 commented Feb 11, 2020

Putting this after #11785 so we can utilize the new label ;-)

@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 11, 2020
@miri64
Copy link
Copy Markdown
Member

miri64 commented Feb 11, 2020

Putting this after #11785 so we can utilize the new label ;-)

Welp... it wasn't merged when the build started, so this was a bit of a waste of time ^^" Sorry

@miri64 miri64 merged commit 8c21747 into RIOT-OS:master Feb 11, 2020
@chrysn chrysn deleted the nordic-softdevice-ipsp-warning branch February 13, 2020 08:49
@leandrolanzieri leandrolanzieri added this to the Release 2020.04 milestone Feb 20, 2020
@kaspar030 kaspar030 mentioned this pull request Mar 4, 2020
Merged
@fjmolinas
Copy link
Copy Markdown
Contributor

fjmolinas commented Apr 2, 2020 •
edited
Loading

Should we add a concrete deprecation date? We have removed it from testing and I though this was actually scheduled for deprecation but the warning is currently ambiguous IMO.

@miri64
Copy link
Copy Markdown
Member

miri64 commented Apr 3, 2020

Should we add a concrete deprecation date?

Probably a good idea.

@chrysn
Copy link
Copy Markdown
Member Author

chrysn commented Apr 3, 2020

"Will be deprecated starting with the 2020.04 release?" There's still time to get that in, and if it's already not tested any more, it'd be a good time now to get it into the release changes.

@fjmolinas
Copy link
Copy Markdown
Contributor

fjmolinas commented Apr 6, 2020

"Will be deprecated starting with the 2020.04 release?" There's still time to get that in, and if it's already not tested any more, it'd be a good time now to get it into the release changes.

Sounds good. I would propose adding that to ``pkg/nordic_softdevice_ble/doc.txt` as a note:

 * @defgroup pkg_nordic-softdevice-ble   Nordic Softdevice BLE
 * @ingroup  pkg
 * @ingroup  net
 *
 * @brief    Provides a RIOT adaption for Nordic Softdevice BLE library
 *
 * @note    Will be deprecated starting with the 2020.04 release

Once 2020.04 is officially announced we change that to a * @deprecated Will be removed starting with the 2020.07 release or 2020.10.

This was referenced May 15, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miri64 miri64 miri64 approved these changes

Assignees

No one assigned

Labels

Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2020.04

Development

Successfully merging this pull request may close these issues.

nordic_softdevice_ble: Update to allow modern kernels for IPSP

5 participants

@chrysn @miri64 @fjmolinas @benpicco @leandrolanzieri