Skip to content

murdock: allow skipping of PR builds#11785

Closed
kaspar030 wants to merge 2 commits intoRIOT-OS:masterfrom
kaspar030:murdock_skip_support
Closed

murdock: allow skipping of PR builds#11785
kaspar030 wants to merge 2 commits intoRIOT-OS:masterfrom
kaspar030:murdock_skip_support

Conversation

@kaspar030
Copy link
Copy Markdown
Contributor

@kaspar030 kaspar030 commented Jul 3, 2019 •
edited
Loading

Contribution description

This PR adds support for not running a build by having "[ci skip]" in the HEAD commit message.

The check is hooked into both the job collection (to skip it), and into "static-tests" (to report an error and fail the build).

WIP

Testing procedure

There's a test commit that fails the build. Here's the output:

-- running on worker riotbuild-6 thread 2, build number 124353.
--> "Skipping build: [ci skip] found in HEAD commit subject."

Issues/PRs references

@kaspar030 kaspar030 added State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: CI Area: Continuous Integration of RIOT components and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jul 3, 2019
@kaspar030 kaspar030 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jul 12, 2019
@kaspar030 kaspar030 force-pushed the murdock_skip_support branch from 7fc2c7b to 3cd8a06 Compare July 12, 2019 12:35
@kaspar030 kaspar030 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jul 12, 2019
@miri64
Copy link
Copy Markdown
Member

miri64 commented Jul 12, 2019

Can you put bb180d0 (or cherry-pick a copy) so the effect is visible with your fixups? Or are you still testing yourself?

@kaspar030 kaspar030 removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jul 12, 2019
@kaspar030
Copy link
Copy Markdown
Contributor Author

kaspar030 commented Jul 12, 2019

still testing. locally it works perfectly, somehow not in the murdock checkout...

@kaspar030 kaspar030 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jul 12, 2019
@kaspar030 kaspar030 force-pushed the murdock_skip_support branch from 3e986cf to 4f0164b Compare July 12, 2019 13:26
@stale
Copy link
Copy Markdown

stale bot commented Jan 13, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

@stale stale bot added the State: stale State: The issue / PR has no activity for >185 days label Jan 13, 2020
@miri64
Copy link
Copy Markdown
Member

miri64 commented Jan 13, 2020

Since the stale bot brought this back to my attention: doesn't it make more sense if this were upstream in kaspar030/murdock?

@stale stale bot removed the State: stale State: The issue / PR has no activity for >185 days label Jan 13, 2020
@miri64 miri64 mentioned this pull request Feb 11, 2020
Merged
@stale
Copy link
Copy Markdown

stale bot commented Jul 16, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

@stale stale bot added the State: stale State: The issue / PR has no activity for >185 days label Jul 16, 2020
@miri64 miri64 removed the State: stale State: The issue / PR has no activity for >185 days label Jul 16, 2020
@fjmolinas
Copy link
Copy Markdown
Contributor

fjmolinas commented Sep 22, 2020

Is there a difference between this and CI: skip compile test?

@miri64
Copy link
Copy Markdown
Member

miri64 commented Sep 22, 2020

The label can only be set by contributors with triaging rights and only PR-wise. This change allows for having this commit-wise and done by the contributor who provides the change.

@fjmolinas
Copy link
Copy Markdown
Contributor

fjmolinas commented Sep 22, 2020

The label can only be set by contributors with triaging rights and only PR-wise. This change allows for having this commit-wise and done by the contributor who provides the change.

Ah thanks, I should stop reading diagonally through a Pr description.

@stale
Copy link
Copy Markdown

stale bot commented Jun 3, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

@stale stale bot added the State: stale State: The issue / PR has no activity for >185 days label Jun 3, 2021
@miri64
Copy link
Copy Markdown
Member

miri64 commented Jun 4, 2021

@kaspar030 any plans to work on this further?

@stale stale bot removed the State: stale State: The issue / PR has no activity for >185 days label Jun 4, 2021
@MrKevinWeiss MrKevinWeiss added this to the Release 2021.07 milestone Jun 21, 2021
@MrKevinWeiss MrKevinWeiss removed this from the Release 2021.07 milestone Jul 15, 2021
@kaspar030 kaspar030 force-pushed the murdock_skip_support branch 3 times, most recently from d008626 to 7df35ad Compare December 18, 2021 11:34
@kaspar030 kaspar030 force-pushed the murdock_skip_support branch from 7df35ad to aad67b9 Compare December 18, 2021 11:35
@kaspar030
Copy link
Copy Markdown
Contributor Author

kaspar030 commented Dec 18, 2021

Since the stale bot brought this back to my attention: doesn't it make more sense if this were upstream in kaspar030/murdock?

probably, not even queueing the build would be best. @aabadie's rewrite supports this already.
Anyhow, this change is simple enough and might save some CI cycles.

I think this is ready for review!

@kaspar030 kaspar030 removed the State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet label Dec 18, 2021
@kaspar030
Copy link
Copy Markdown
Contributor Author

kaspar030 commented Feb 9, 2022

closing this one, doesn't seem to scratch enough itch

@kaspar030 kaspar030 closed this Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss

Assignees

No one assigned

Labels

Area: CI Area: Continuous Integration of RIOT components CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kaspar030 @miri64 @fjmolinas @MrKevinWeiss