drivers: fix includes in rtc.h for MSP430#1073
Merged
OlegHahm merged 1 commit intoRIOT-OS:masterfrom Apr 30, 2014
Kijewski:rtc-sys_time
Merged
drivers: fix includes in rtc.h for MSP430#1073OlegHahm merged 1 commit intoRIOT-OS:masterfrom Kijewski:rtc-sys_time
OlegHahm merged 1 commit intoRIOT-OS:masterfrom
Kijewski:rtc-sys_time
Conversation
The comment and the actual guard in `rtc.h` did not match. If (as in "implication") the MCU is an MSP, then `sys/time.h` must be included, to have `time_t`, `struct timeval`, … Including the header file in any case should be safe, so I dropped the guard altogether.
Member
|
I think the issue was that there was not |
Contributor
Author
|
Dunno, but now there is: https://github.com/RIOT-OS/RIOT/blob/master/cpu/msp430-common/include/sys/time.h [edit] Oh, and actually you added the stub. :) [/edit] |
Member
|
Ah, thanks for refreshing my memory. In this case: ACK and go! |
OlegHahm
added a commit
that referenced
this pull request
Apr 30, 2014
drivers: fix includes in rtc.h for MSP430
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comment and the actual guard in
rtc.hdid not match.If (as in "implication") the MCU is an MSP, then
sys/time.hmust beincluded, to have
time_t,struct timeval, …Including the header file in any case should be safe, so I dropped the
guard altogether.