Makefile.include: remove functionality to build with another version.#10543
Merged
aabadie merged 1 commit intoRIOT-OS:masterfrom Jan 17, 2019
Merged
Conversation
Makefile.include contained logic to clone a different RIOT version and build the application against it. This can be easily achieved by making a git worktree and overriding RIOTBASE, without adding any complexity to our makefiles. Therefore, the feature is being removed.
Contributor
|
I also planned to remove it for some time, it introduces a specific branch in the main Makefile.include for something I would not want included in there. Removing it will also simplify cleaning other things. Maybe we should put a deprecation error for one full release to see if somebody complains. |
Contributor
|
We do not maintain compatibility with previous versions, even build with docker cannot work, so I do not like having something making think it is the case. If |
cladmi
approved these changes
Jan 17, 2019
Contributor
There was a problem hiding this comment.
ACK, I wanted to remove it too as it confused me a lot when setting RIOT_VERSION instead of RIOT_VERSION_OVERRIDE.
There was no objections until now. Also it can easily be reverted/proposed differently if someone complains.
We can merge when murdock is happy.
aabadie
approved these changes
Jan 17, 2019
Contributor
aabadie
left a comment
There was a problem hiding this comment.
Looks good and would be great to have this for the release.
ACK and go
cladmi
added a commit
to cladmi/RIOT
that referenced
this pull request
Jul 1, 2019
RIOT_VERSION is not used for building a specific RIOT version anymore since RIOT-OS#10543. The variable can now be used directly. When building with `RIOT_CI_BUILD=1` this also now prevents calling `git describe` and `git rev-parse` which saves around 0.1 seconds per execution on my machine.
cladmi
added a commit
to cladmi/RIOT
that referenced
this pull request
Jul 1, 2019
RIOT_VERSION is not used for building a specific RIOT version anymore since RIOT-OS#10543. The variable can now be used directly. When building with `RIOT_CI_BUILD=1` this also now prevents calling `git describe` and `git rev-parse` which saves around 0.1 seconds per execution on my machine.
cladmi
added a commit
to cladmi/RIOT
that referenced
this pull request
Jul 5, 2019
RIOT_VERSION is not used for building a specific RIOT version anymore since RIOT-OS#10543. The variable can now be used directly. When building with `RIOT_CI_BUILD=1` this also now prevents calling `git describe` and `git rev-parse` which saves around 0.1 seconds per execution on my machine.
cladmi
added a commit
to cladmi/RIOT
that referenced
this pull request
Jul 8, 2019
RIOT_VERSION is not used for building a specific RIOT version anymore since RIOT-OS#10543. The variable can now be used directly. When building with `RIOT_CI_BUILD=1` this also now prevents calling `git describe` and `git rev-parse` which saves around 0.1 seconds per execution on my machine.
cladmi
added a commit
to cladmi/RIOT
that referenced
this pull request
Jul 18, 2019
RIOT_VERSION is not used for building a specific RIOT version anymore since RIOT-OS#10543. The variable can now be used directly. When building with `RIOT_CI_BUILD=1` this also now prevents calling `git describe` and `git rev-parse` which saves around 0.1 seconds per execution on my machine.
cladmi
added a commit
to cladmi/RIOT
that referenced
this pull request
Jul 22, 2019
RIOT_VERSION is not used for building a specific RIOT version anymore since RIOT-OS#10543. The variable can now be used directly.
cladmi
added a commit
to cladmi/RIOT
that referenced
this pull request
Jul 24, 2019
RIOT_VERSION is not used for building a specific RIOT version anymore since RIOT-OS#10543. The variable can now be used directly. When building with `RIOT_CI_BUILD=1` this also now prevents calling `git describe` and `git rev-parse` which saves around 0.1 seconds per execution on my machine.
cladmi
added a commit
to cladmi/RIOT
that referenced
this pull request
Jul 25, 2019
RIOT_VERSION is not used for building a specific RIOT version anymore since RIOT-OS#10543. The variable can now be used directly. When building with `RIOT_CI_BUILD=1` this also now prevents calling `git describe` and `git rev-parse` which saves around 0.1 seconds per execution on my machine.
cladmi
added a commit
to cladmi/RIOT
that referenced
this pull request
Jul 29, 2019
RIOT_VERSION is not used for building a specific RIOT version anymore since RIOT-OS#10543. The variable can now be used directly.
cladmi
added a commit
to cladmi/RIOT
that referenced
this pull request
Aug 12, 2019
RIOT_VERSION is not used for building a specific RIOT version anymore since RIOT-OS#10543. The variable can now be used directly. Add deprecation warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Makefile.include contained logic to clone a different RIOT version and build the application against it. This can be easily achieved by making a git worktree and overriding RIOTBASE, without adding any complexity to our makefiles. Therefore, the feature is being removed.
Testing procedure
CI will test that nothing got broken.