cortexm.inc.mk: detect 'arm-none-eabi-gcc' from ubuntu bionic by cladmi · Pull Request #10404 · RIOT-OS/RIOT

cladmi · 2018-11-15T16:23:40Z

Contribution description

arm-gcc version from ubuntu bionic repository is not supported in RIOT.
Both when building with gnu and llvm.

arm-none-eabi-gcc --version
arm-none-eabi-gcc (15:6.3.1+svn253039-1build1) 6.3.1 20170620

So detect this version and print an error if found.

The check is done on the building machine and not on the host when building in
docker.

The error can be disabled when building with WERROR=0.

TODO

Verify it does not fail on murdock "test nodes" when doing only "flash test"
- maybe catch if it is not installed ?
verify mac does not break, the 'sed' command should be safe.

Testing procedure

Not matching your working gcc version

Try compiling anything for samr21-xpro with your working setup, it should produce no error at compilation

Detecting bionic

Try building with ubuntu bionic GCC version (change your PATH) to see the error is detected, and also other "working" gcc versions:

RIOT_CI_BUILD=1 BOARD=samr21-xpro make --no-print-directory -C examples/default/ 
/home/harter/work/git/RIOT/makefiles/arch/cortexm.inc.mk:61: arm-none-eabi-gcc version not supported
/home/harter/work/git/RIOT/makefiles/arch/cortexm.inc.mk:62: arm-none-eabi-gcc (15:6.3.1+svn253039-1build1) 6.3.1 20170620
/home/harter/work/git/RIOT/makefiles/arch/cortexm.inc.mk:63: The currently recommanded version is the one installed in the riotdocker image
/home/harter/work/git/RIOT/makefiles/arch/cortexm.inc.mk:64: https://github.com/RIOT-OS/riotdocker/blob/master/Dockerfile
/home/harter/work/git/RIOT/makefiles/arch/cortexm.inc.mk:66: *** This check can be ignored by building with 'WERROR=0'.  Stop.

You can disable the error with WERROR=0 and still try compiling:

WERROR=0 RIOT_CI_BUILD=1 BOARD=samr21-xpro make --no-print-directory -C examples/default/ 
/home/harter/work/git/RIOT/makefiles/arch/cortexm.inc.mk:61: arm-none-eabi-gcc version not supported
/home/harter/work/git/RIOT/makefiles/arch/cortexm.inc.mk:62: arm-none-eabi-gcc (15:6.3.1+svn253039-1build1) 6.3.1 20170620
/home/harter/work/git/RIOT/makefiles/arch/cortexm.inc.mk:63: The currently recommanded version is the one installed in the riotdocker image
/home/harter/work/git/RIOT/makefiles/arch/cortexm.inc.mk:64: https://github.com/RIOT-OS/riotdocker/blob/master/Dockerfile
Building application "default" for "samr21-xpro" with MCU "samd21".

   text    data     bss     dec     hex filename
  47436     148    6044   53628    d17c /home/harter/work/git/RIOT/examples/default/bin/samr21-xpro/default.elf

When building in docker, no check is done on your machine:

BUILD_IN_DOCKER=1 DOCKER="sudo docker" RIOT_CI_BUILD=1 BOARD=samr21-xpro make --no-print-directory -C examples/default/ 
Launching build container using image "riot/riotbuild:latest".
sudo docker run --rm -t -u "$(id -u)" \
    -v '/home/harter/work/git/RIOT:/data/riotbuild/riotbase' \
    -v '/home/harter/work/git/RIOT/cpu:/data/riotbuild/riotcpu' \
    -v '/home/harter/work/git/RIOT/boards:/data/riotbuild/riotboard' \
    -v '/home/harter/work/git/RIOT/makefiles:/data/riotbuild/riotmake' \
    -v '/home/harter/work/git/RIOT:/data/riotbuild/riotproject' \
    -v /etc/localtime:/etc/localtime:ro \
    -e 'RIOTBASE=/data/riotbuild/riotbase' \
    -e 'CCACHE_BASEDIR=/data/riotbuild/riotbase' \
    -e 'RIOTCPU=/data/riotbuild/riotcpu' \
    -e 'RIOTBOARD=/data/riotbuild/riotboard' \
    -e 'RIOTMAKE=/data/riotbuild/riotmake' \
    -e 'RIOTPROJECT=/data/riotbuild/riotproject' \
    -v /home/harter/.gitcache:/data/riotbuild/gitcache -e GIT_CACHE_DIR=/data/riotbuild/gitcache  \
    -e 'BOARD=samr21-xpro' -e 'RIOT_CI_BUILD=1' \
    -w '/data/riotbuild/riotproject/examples/default/' \
    'riot/riotbuild:latest' make  
Building application "default" for "samr21-xpro" with MCU "samd21".

   text    data     bss     dec     hex filename
  39796     508    6044   46348    b50c /data/riotbuild/riotproject/examples/default/bin/samr21-xpro/default.elf

Issues/PRs references

Was reported here:

cladmi · 2018-11-15T16:24:45Z

@HendrikVE could you also try ?

HendrikVE · 2018-11-16T09:19:42Z

Works good for me, warning is displayed and bypass with WERROR=0 also works.

miri64

Still works without warning on Arch and I trust @HendrikVE's testing.

makefiles/arch/cortexm.inc.mk

cladmi · 2018-12-06T11:37:39Z

Updated (not sure it sent a message)

miri64

I set-up a VM using https://app.vagrantup.com/ubuntu/boxes/bionic64 and installed the toolchain via apt-get:

sudo apt-get update
sudo apt-get install gcc-arm-none-eabi unzip build-essential
arm-none-eabi-gcc --version

arm-none-eabi-gcc (15:6.3.1+svn253039-1build1) 6.3.1 20170620
Copyright (C) 2016 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

However, when following the testing procedures I don't get the expected result:

RIOT_CI_BUILD=1 BOARD=samr21-xpro make --no-print-directory -C examples/default/

Building application "default" for "samr21-xpro" with MCU "samd21".
make[1]: Warning: File '/home/vagrant/RIOT/examples/default/bin/samr21-xpro/riotbuild/riotbuild.h' has modification time 1 s in the future
make[2]: Warning: File '/home/vagrant/RIOT/examples/default/bin/samr21-xpro/riotbuild/riotbuild.h' has modification time 0.56 s in the future
make[2]: warning:  Clock skew detected.  Your build may be incomplete.
make[2]: Warning: File '/home/vagrant/RIOT/examples/default/bin/samr21-xpro/riotbuild/riotbuild.h' has modification time 0.16 s in the future
make[2]: warning:  Clock skew detected.  Your build may be incomplete.
make[1]: warning:  Clock skew detected.  Your build may be incomplete.
make: Warning: File '/home/vagrant/RIOT/examples/default/bin/samr21-xpro/stdio_uart.a' has modification time 0.027 s in the future
   text	   data	    bss	    dec	    hex	filename
  47436	    148	   6044	  53628	   d17c	/home/vagrant/RIOT/examples/default/bin/samr21-xpro/default.elf
make: warning:  Clock skew detected.  Your build may be incomplete.

miri64 · 2019-01-09T16:03:21Z

makefiles/arch/cortexm.inc.mk

+    $(warning $(shell $(TARGET_ARCH)-gcc --version | head -n 1))
+    $(warning The currently recommanded version is the one installed in the riotdocker image)
+    $(warning https://github.com/RIOT-OS/riotdocker/blob/master/Dockerfile)
+    ifeq (1,$(WERROR))


From the error message below I would expect it to be checked with ifneq (0,$(WERROR))

I tried to be consistent with the other handling of WERROR

RIOT/Makefile.include

Lines 141 to 144 in 6a8808c

# Fail on warnings. Can be overridden by `make WERROR=0`.

WERROR ?= 1

export WERROR

ifeq ($(WERROR),1)

Mhhhh... Ok for now, but we should think about if it isn't more clearer the other way around (afaics only WERROR=0 is documented, nothing is said about WERROR=<random number != 0>

cladmi · 2019-01-10T11:07:31Z

On my machine I get the message… I will try with the vagrant image.

What do you get with

RIOT_CI_BUILD=1 BOARD=samr21-xpro WERROR=0 make --no-print-directory -C examples/default/ info-debug-variable-ARM_GCC_VERSION ?

cladmi · 2019-01-10T11:21:22Z

It correctly fails with the test command in a vagrant image. Did you remember to checkout the branch before testing in the VM ?
I did the mistake on first test…

miri64 · 2019-01-10T11:36:05Z

It correctly fails with the test command in a vagrant image. Did you remember to checkout the branch before testing in the VM ?
I did the mistake on first test…

Pretty sure I did, but let me try again ;-)

miri64 · 2019-01-10T11:42:25Z

It correctly fails with the test command in a vagrant image. Did you remember to checkout the branch before testing in the VM ?
I did the mistake on first test…

Pretty sure I did, but let me try again ;-)

Arghs, though I mounted the repo from the host machine, I hooked it into a different repo then the one I checked out the PR in (I copied the config for the VM from my #9942 test setup where I did not want to interfere with my development cycle).

miri64 · 2019-01-10T11:43:15Z

Now it works as expected. Sorry for the noise -.-

miri64

Tested on Arch Linux, Ubuntu 16.04, Ubuntu 18.04 (both with apt-get toolchain and the one used in the docker container). Works as expected. Note that for Ubuntu 16.04 I used the GCC from this source (why aren't we using that one in the docker btw?):

deb http://ppa.launchpad.net/team-gcc-arm-embedded/ppa/ubuntu xenial main
# deb-src http://ppa.launchpad.net/team-gcc-arm-embedded/ppa/ubuntu xenial main

To test the right GCC on Ubuntu 18.04 I did as done here https://github.com/RIOT-OS/riotdocker/blob/97c77bd8fe9f7e63d0ac4f2f1fd4357e779ab5fb/Dockerfile#L100-L107 and rerouted the PATH:

PATH=/opt/gcc-arm-none-eabi-7-2018-q2-update/bin/:$PATH RIOT_CI_BUILD=1 BOARD=samr21-xpro make --no-print-directory -C examples/default/

ACK!

miri64 · 2019-01-10T11:52:48Z

(please squash)

cladmi · 2019-01-10T12:25:54Z

We are not using the PPA anymore to have an explicit version number and choice and also help migrating releases.
RIOT-OS/riotdocker#53

arm-gcc version from ubuntu bionic repository is not supported in RIOT. Both when building with `gnu` and `llvm`. arm-none-eabi-gcc --version arm-none-eabi-gcc (15:6.3.1+svn253039-1build1) 6.3.1 20170620 So detect this version and print an error if found. The check is done on the building machine and not on the host when building in docker. The error can be disabled when building with WERROR=0.

cladmi · 2019-01-10T12:28:33Z

I rebased then squashed in two steps.

miri64 · 2019-01-10T13:44:09Z

Then let's go

cladmi · 2019-01-10T14:49:17Z

Thank you for reviewing and testing.

cladmi requested review from adjih, dylad, jnohlgard, kb2ma and smlng November 15, 2018 16:23

cladmi force-pushed the pr/arm/warning_on_ubuntu_bionic_gcc branch from 4f39f86 to 1facdd1 Compare November 15, 2018 16:24

cladmi mentioned this pull request Nov 15, 2018

__libc_init_array() crash (newlib) #9248

Closed

cladmi added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 16, 2018

cladmi added this to the Release 2019.01 milestone Nov 23, 2018

miri64 reviewed Nov 27, 2018

View reviewed changes

makefiles/arch/cortexm.inc.mk Outdated Show resolved Hide resolved

dylad mentioned this pull request Nov 27, 2018

stm32f4discovery isn't visible as ttyUSB after flashing with tests/leds #10463

Closed

miri64 requested changes Jan 9, 2019

View reviewed changes

miri64 approved these changes Jan 10, 2019

View reviewed changes

cladmi force-pushed the pr/arm/warning_on_ubuntu_bionic_gcc branch from 1e9c4aa to a06519e Compare January 10, 2019 12:26

cladmi force-pushed the pr/arm/warning_on_ubuntu_bionic_gcc branch from a06519e to 89d7e2e Compare January 10, 2019 12:27

miri64 merged commit a09dc18 into RIOT-OS:master Jan 10, 2019

cladmi deleted the pr/arm/warning_on_ubuntu_bionic_gcc branch January 10, 2019 14:50

aabadie modified the milestone: Release 2019.01 Jan 11, 2019

cladmi mentioned this pull request Sep 2, 2019

makefiles/cflags.inc.mk: handle optional cflags #12123

Merged

	# Fail on warnings. Can be overridden by `make WERROR=0`.
	WERROR ?= 1
	export WERROR
	ifeq ($(WERROR),1)

Conversation

cladmi commented Nov 15, 2018 • edited by miri64 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution description

TODO

Testing procedure

Not matching your working gcc version

Detecting bionic

Issues/PRs references

Uh oh!

cladmi commented Nov 15, 2018

Uh oh!

HendrikVE commented Nov 16, 2018

Uh oh!

miri64 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cladmi commented Dec 6, 2018

Uh oh!

miri64 left a comment

Choose a reason for hiding this comment

Uh oh!

miri64 Jan 9, 2019

Choose a reason for hiding this comment

Uh oh!

cladmi Jan 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

miri64 Jan 10, 2019

Choose a reason for hiding this comment

Uh oh!

cladmi commented Jan 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cladmi commented Jan 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

miri64 commented Jan 10, 2019

Uh oh!

miri64 commented Jan 10, 2019

Uh oh!

miri64 commented Jan 10, 2019

Uh oh!

miri64 left a comment

Choose a reason for hiding this comment

Uh oh!

miri64 commented Jan 10, 2019

Uh oh!

cladmi commented Jan 10, 2019

Uh oh!

cladmi commented Jan 10, 2019

Uh oh!

miri64 commented Jan 10, 2019

Uh oh!

cladmi commented Jan 10, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cladmi commented Nov 15, 2018 •

edited by miri64

Loading

cladmi Jan 10, 2019 •

edited

Loading

cladmi commented Jan 10, 2019 •

edited

Loading

cladmi commented Jan 10, 2019 •

edited

Loading