Skip to content

ARM: Use ARM provided toolchain archive instead of PPA#53

Merged
cladmi merged 2 commits intoRIOT-OS:masterfrom
jnohlgard:pr/arm-toolchain
Oct 9, 2018
Merged

ARM: Use ARM provided toolchain archive instead of PPA#53
cladmi merged 2 commits intoRIOT-OS:masterfrom
jnohlgard:pr/arm-toolchain

Conversation

@jnohlgard
Copy link
Copy Markdown
Member

@jnohlgard jnohlgard commented Oct 8, 2018

The purpose of this change is to make the build more explicit with regards to toolchain versions, and to make the ARM installation more similar to the other supported platforms in the container. This will also make transitioning to a newer OS release (#42) easier.
The MD5 sum is verified after download against the expected MD5 sum from the ARM website, this way the user can be certain that this image uses a particular version of the toolchain.
The selected toolchain is the latest release currently available from arm.com, and the same release as found in the PPA. I did not verify that the files are the same in the downloaded archive as in the PPA, but they carry the same GCC version number, so the impact should be minimal.

@jnohlgard jnohlgard requested a review from cladmi October 8, 2018 07:43
@cladmi
Copy link
Copy Markdown
Contributor

cladmi commented Oct 9, 2018

I am building the image and will check I can still do a "buildtest" with it.

(I will remove this cmake compiling from source it takes ages to compile and they already provide a binary version…).

@jnohlgard
Copy link
Copy Markdown
Member Author

jnohlgard commented Oct 9, 2018 •
edited
Loading

@cladmi after this we can update #42 to get rid of the cmake build and other hacks

@cladmi
Copy link
Copy Markdown
Contributor

cladmi commented Oct 9, 2018

We are currently already using this version (from the print_toolchain output in murdock).

arm-none-eabi-gcc (GNU Tools for Arm Embedded Processors 7-2018-q3-update) 7.3.1 20180622 (release) [ARM/embedded-7-branch revision 261907]

Maybe we should directly use this one here.

@jnohlgard
Copy link
Copy Markdown
Member Author

jnohlgard commented Oct 9, 2018

The latest available release on arm.com is 7-2018-q2-update. q3 is not available yet.

@cladmi
Copy link
Copy Markdown
Contributor

cladmi commented Oct 9, 2018

Ok.

@cladmi
Copy link
Copy Markdown
Contributor

cladmi commented Oct 9, 2018

Good for me, I could run buildtest for examples/hello-world and I checked it's using the /opt/gcc-arm-none-eabi-7-2018-q2-update.

I am completely in favor of fixing versions.

@cladmi
Copy link
Copy Markdown
Contributor

cladmi commented Oct 9, 2018

It is also 0.06GB smaller than master.

@cladmi
Copy link
Copy Markdown
Contributor

cladmi commented Oct 9, 2018

I rerun the build to be with the last master and have the travis output. Will merge on success.

@cladmi
Copy link
Copy Markdown
Contributor

cladmi commented Oct 9, 2018

Hmm… is not travis supposed to test the merge version with master ?
I do not see the build size output. Or maybe it is parsed before merging. Anyway ACK.

@cladmi cladmi merged commit f1de5f3 into RIOT-OS:master Oct 9, 2018
@jnohlgard jnohlgard deleted the pr/arm-toolchain branch October 9, 2018 12:47
@ZetaR60 ZetaR60 mentioned this pull request Oct 10, 2018
Merged
@jia200x jia200x mentioned this pull request Oct 15, 2018
Closed
@cladmi cladmi mentioned this pull request Jan 10, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cladmi cladmi cladmi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jnohlgard @cladmi