tests/heatshrink: move from unittests to regular test#10202
Merged
bergzand merged 1 commit intoRIOT-OS:masterfrom Oct 19, 2018
Merged
tests/heatshrink: move from unittests to regular test#10202bergzand merged 1 commit intoRIOT-OS:masterfrom
bergzand merged 1 commit intoRIOT-OS:masterfrom
Conversation
16 tasks
ac12f26 to
e39d7c2
Compare
bergzand
requested changes
Oct 19, 2018
Member
bergzand
left a comment
There was a problem hiding this comment.
I think tests/pkg_heatshrink/Makefile.include can be fully removed here. Otherwise ACK, feel free to directly squash the changes.
Member
Author
|
@bergzand yes, my bad ... |
Member
|
Looks like the arduino-{duemilanove,uno} and the nucleo-f031k6 have to be added to the insufficient memory list |
e26565c to
1e5faed
Compare
Member
|
Re-ACK :) |
Member
Author
|
okay then I'll squash |
This moves tests for the heatshrink package from unittests to a regular test, which should help to decrease binary size of unittests.
fbabc73 to
24032ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This moves tests for the heatshrink package from unittests to a regular
test, which should help to decrease binary size of unittests.
Testing procedure
run the tests, i.e.
BOARD=<your-favourite> make -C tests/pkg_heatshrink flash testIssues/PRs references