tests/cn-cbor: move from unittests to regular test#10188
tests/cn-cbor: move from unittests to regular test#10188miri64 merged 1 commit intoRIOT-OS:masterfrom
Conversation
| wsn430-v1_3b \ | ||
| wsn430-v1_4 \ | ||
| z1 \ | ||
| # |
There was a problem hiding this comment.
I don't understand this lonely comment either.
There was a problem hiding this comment.
its done in other tests, too see https://github.com/RIOT-OS/RIOT/blob/master/tests/unittests/Makefile#L192 - but its not consistent. I thought it makes it easier to add a board to the list - simply by putting <board> \
There was a problem hiding this comment.
What is the reason for the BLACKLIST here ?
If it is a size issue they should just be put as BOARD_INSUFFICIENT_MEMORY.
There was a problem hiding this comment.
Ok they fail with string.h EDIT strings.h not found. Tested compiling arduino-mega2560 and wsn430-v1_3b.
|
can I squash? |
cladmi
left a comment
There was a problem hiding this comment.
Tested on iotlab-m3 and samr21-xpro.
Changes requests inline.
cladmi
left a comment
There was a problem hiding this comment.
Tested with IoT-LAB and the following boards/command (only tested with gcc):
BOARDS="samr21-xpro pba-d-01-kw2x b-l475e-iot01a nrf52dk arduino-zero nrf52840dk iotlab-m3 microbit frdm-kw41z"
for board in ${BOARDS}; do BOARD=${board} RIOT_CI_BUILD=1 IOTLAB_NODE=auto-ssh BUILD_IN_DOCKER=1 DOCKER="sudo docker" make --no-print-directory -C tests/pkg_cn-cbor/ clean all flash test || break; done
Please squash.
|
To be precise, I tested the rebase on master to have all IoT-LAB nodes available. |
e8b1e63 to
6fdb55c
Compare
tests/pkg_cn-cbor/tests/01-run.py
Outdated
|
|
||
|
|
||
| def testfunc(child): | ||
| child.expect('OK \(\d+ tests\)') |
There was a problem hiding this comment.
Same error here with the regex string. You can squash directly.
There was a problem hiding this comment.
fixed and squashed directly
This moves tests for the cn-cbor package from unittests to a regular test, which should help to decrease binary size of unittests.
6fdb55c to
7b0a7db
Compare
|
Thank you for doing the migration! |
Contribution description
This moves tests for the cn-cbor package from unittests to a regular
test, which should help to decrease binary size of unittests.
Testing procedure
run the tests, i.e.
BOARD=<your-favourite> make -C tests/pkg_cn-cbor flash testIssues/PRs references