Skip to content

tests/gnrc_sixlowpan: fix stacksize of dummy device#10024

Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom
miri64:tests/fix/gnrc_sixlowpan-test-stacksize
Sep 25, 2018
Merged

tests/gnrc_sixlowpan: fix stacksize of dummy device#10024
miri64 merged 1 commit intoRIOT-OS:masterfrom
miri64:tests/fix/gnrc_sixlowpan-test-stacksize

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Sep 24, 2018

Contribution description

This was already too small in #9648 so it should have been properly
tested. Now that we are testing it on CI with binaries compiled by LLVM
this leads to crashes with this "new" platform.

Testing procedure

Compile tests/sixlowpan for samr21-xpro with LLVM, flash to board and run tests:

TOOLCHAIN=llvm BOARD=samr21-xpro make -C tests/gnrc_sixlowpan flash test

Without this fix you should have a failed test / a crash with no/limited output. This PR fixes that.

Issues/PRs references

Discovered in #9809.

This was already too small in 6c2510d so it should have been properly
tested. Now that we are testing it on CI with binaries compiled by LLVM
this leads to crashes with this "new" platform.
@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR labels Sep 24, 2018
@miri64 miri64 requested review from cladmi and kaspar030 September 24, 2018 14:23
@miri64 miri64 added this to the Release 2018.10 milestone Sep 24, 2018
Copy link
Copy Markdown
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(untested) ACK.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 24, 2018

(I put it into #9809 so it will be run and tested on Murdock)

@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Sep 24, 2018
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 25, 2018

In #9809 every test except static tests (because of fixups in #10014) passed now. Let's go!

@miri64 miri64 merged commit c3cc010 into RIOT-OS:master Sep 25, 2018
@miri64 miri64 deleted the tests/fix/gnrc_sixlowpan-test-stacksize branch September 25, 2018 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants