Skip to content

feat: "Install PR" UI#197

Merged
GeckoEidechse merged 10 commits intoR2NorthstarTools:feat/install-prfrom
Alystrasz:feat/install-pr-ui
Feb 28, 2023
Merged

feat: "Install PR" UI#197
GeckoEidechse merged 10 commits intoR2NorthstarTools:feat/install-prfrom
Alystrasz:feat/install-pr-ui

Conversation

@Alystrasz
Copy link
Copy Markdown
Collaborator

Little improvements over the PR installation feature:

  • PRs are fetched on collapse item click;
  • Loaders indicate PRs are being fetched.

I could improve things more, but since it's a developer feature, it doesn't need more polish imo :)

Capture d’écran de 2023-02-28 08-21-35

Copy link
Copy Markdown
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From quick test everything still works as expected. Love the load on collapse open btw <3

The only thing I'd change is removing the accordion attribute, then it should be good to merge ^^

Co-authored-by: GeckoEidechse <40122905+GeckoEidechse@users.noreply.github.com>
Copy link
Copy Markdown
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working as intended now :D

@GeckoEidechse GeckoEidechse merged commit 2e38f7a into R2NorthstarTools:feat/install-pr Feb 28, 2023
@GeckoEidechse GeckoEidechse mentioned this pull request Mar 1, 2023
100 tasks
Alystrasz added a commit that referenced this pull request Mar 2, 2023
* feat: Initial backend code to get list of PRs

Hardcoded for launcher right now

* refactor: Autogen TS bindings from Rust code
using `ts-rs` as done in #140

* fix: Fix incorrect typing

What is returned is actually an array of `PullsApiResponseElement`

* feat: Prototyping frontend UI for installing PR

* fix: Use right repo

Used Mods instead of Launcher

* feat: Enable installing launcher pull request

* refactor: Rename variables to indicate approp repo

NorthstarLauncher vs NorthstarMods

* style: Formatting fixes

* feat: Initial code for getting mods PRs

* feat: Add backend code for installing mods PRs

* feat: Add note about launching in notification

* fix: Remove commented out code

* refactor: Depduplicate code

* refactor: Remove unnecessary use of anyhow

* refactor: Use already existing function
for checking game path

* feat: Add comment about profile / batch file

* chore: Remove leftover print statements

* feat: Add clickable link for each PR

* refactor: Reduce duplicate code

* refactor: Rename enum

* fix: Use proper type

* fix: Remove leftover `console.log`s

* style: Revert accidental formatting change

* refactor: Remove second API call for mods PRs

* refactor: Rename variable

* refactor: Remove second API call for launcher PRs

* refactor: Move API URL string to `constants.rs`

So that all constants are in a single place

* fix: Restore lines deleted in merge

* style: Formatting fixes

* fix: Print line when done installing PR

* feat: Show notification for install start/done

Displays a notification that PR install has started and upon completion
replaces it with one saying that install has completed.

* fix: Remove left-over console log

* feat: "Install PR" UI (#197)

* refactor: export pull requests selector to dedicated component

* refactor: regroup launcher+mods collapses in one collapse component

* refactor: load pull requests when opening selector collapse item

* refactor: review progress loaders' style

* fix: don't fetch PRs if they've already been loaded

* feat: update collapse style

* refactor: remove fetch success notification

* refactor: both collapses can be opened at the same time

* fix: non-accordion collapse sends an object as event parameter

* fix: Iterate over multiple pages of GitHub CI API
This ensures we can still grab older artifacts.

Max page is capped at 10 as going too high will cause us to hit API rate
limits.

Also refined error message accordingly.

* refactor: Move stored PRs to submodule
as suggested in review

* refactor: Move getPullRequests to store submodule

I order to clean up PullRequestSelector.vue

Other functions will follow in separate commits.

Currently TypeScript compilation fails on undefined type of `state`

* fix: Properly define state type

* refactor: Move installLauncherPR to store submodule

* refactor: Move installModsPR to store submodule

---------

Co-authored-by: Rémy Raes <contact@remyraes.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants