ci: extend qwen PR review timeout to 90min and queue delay to 30min#4962
Merged
Conversation
wenshao
approved these changes
Jun 10, 2026
Collaborator
|
Thanks for the PR, @yiliang114! Template looks good ✓ On direction: Straightforward CI timeout tuning — larger PRs hitting the 60-min ceiling is a real operational pain point. Clearly within scope. No CHANGELOG precedent needed for CI config changes. On approach: All four Moving on to code review. 🔍 中文说明感谢贡献，@yiliang114！ 模板完整 ✓ 方向：直接解决运维痛点——大 PR 在 review 完成前撞到 60 分钟超时上限。属于 CI 配置调优，范围明确。 方案：四处 进入代码审查 🔍 — Qwen Code · qwen3.7-max |
Collaborator
Code ReviewFive hunks, all in
All four timeout sites move together consistently. YAML parses cleanly on both sides of the diff. No correctness issues, no security concerns. The diff is exactly what the PR description promises — nothing more, nothing less. One observation: the queue-delay comment says 30 minutes but only the comment is updated in code. The PR body correctly notes the actual timer must be adjusted in repo settings (environment TestingN/A — this is a CI workflow YAML change with no user-facing behavior. tmux real-scenario testing does not apply. YAML parse validation: passes ( 中文说明代码审查
四处超时值同步修改，YAML 解析正常。无正确性或安全问题。Diff 与 PR 描述完全一致。 注意：排队等待注释更新为 30 分钟，但实际计时器需在仓库 测试不适用——CI workflow YAML 变更，无用户可见行为变化。 — Qwen Code · qwen3.7-max |
Collaborator
ReflectionThis is as clean as CI config changes get: four timeout values move in lockstep, the YAML is valid, the diff matches the description exactly, and the risk (a hung review holding a self-hosted runner for 90 instead of 60 minutes) is explicitly acknowledged and acceptable given the operational need. The only thing worth a maintainer's attention before merge: the No concerns. LGTM. ✅ 中文说明总结这是一个非常干净的 CI 配置变更：四处超时值同步修改，YAML 格式正确，diff 与描述完全一致。风险（卡死的 review 占用 runner 90 分钟）已明确说明且可接受。 唯一需要维护者在合入前确认：仓库 无顾虑，可以合入。✅ — Qwen Code · qwen3.7-max |
qwen-code-ci-bot
approved these changes
Jun 10, 2026
qwen-code-ci-bot
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, looks ready to ship. ✅
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the automated Qwen PR review GitHub Actions workflow to accommodate larger pull requests by extending the maximum allowed review runtime and aligning the workflow’s validation and documentation with the new limits.
Changes:
- Increase
timeout_minutesworkflow dispatch default from 60 → 90 minutes. - Increase the
review-prjobtimeout-minutesfrom 60 → 90 minutes and align the runtime fallback and validation cap accordingly. - Update the inline note about the
qwen-pr-review-delayenvironment wait timer to 30 minutes (documentation-only; timer is configured in repo settings).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wenshao
reviewed
Jun 10, 2026
wenshao
left a comment
Collaborator
There was a problem hiding this comment.
No issues found. Downgraded from Approve to Comment: CI still running. LGTM! ✅ — qwen3.7-max via Qwen Code /review
yiliang114
added a commit
that referenced
this pull request
Jun 10, 2026
PR #4962 extends the old qwen-code-pr-review.yml timeouts (review 60->90min, delay comment 10->30min). That file is deleted here — its intent is already implemented in the qwen-pr-triage.yml pipeline (review timeout 90min with a workflow_dispatch override). Resolved the modify/delete conflict by keeping the deletion; merging the branch lets #4962 auto-close as merged when this PR lands.
yiliang114
added a commit
that referenced
this pull request
Jun 10, 2026
The qwen-pr-review-delay environment wait timer is set to 30 minutes (per #4962); update the stale 1-hour comments to match.
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Extends two time limits in the automated PR review workflow: the review run timeout goes from 60 to 90 minutes (dispatch input default, job
timeout-minutes, fallback value, and the validation cap), and the documented auto-review queue delay goes to 30 minutes.The queue delay itself lives in the
qwen-pr-review-delayenvironment's wait timer (repo settings), so this PR only updates the stale comment — the actual timer is adjusted in settings alongside this change.Why it's needed
Larger PRs have been hitting the 60-minute ceiling before the review completes. Extracted from #4866 so the timeout bump can land independently of the pipeline refactor.
Reviewer Test Plan
How to verify
Config-only change — all four
60 → 90sites move together (input default, job timeout, fallback, validation cap), so an explicittimeout_minutes=90dispatch passes validation and stays under the job timeout. YAML parses; actionlint reports only the pre-existing warnings (customecs-qwenlabel,deploymentkey).Evidence (Before & After)
N/A (CI config).
Tested on
Risk & Scope
Linked Issues
Extracted from #4866.
中文说明
把自动 PR review workflow 的两个时间上限放宽：review 运行超时从 60 分钟扩到 90 分钟（dispatch 输入默认值、job
timeout-minutes、回退值、校验上限四处同步），自动 review 的排队等待时间注释更新为 30 分钟。排队等待实际由
qwen-pr-review-delayenvironment 的 wait timer（仓库设置）控制，本 PR 只修正过期注释，真实计时器随本改动在设置中调整。为什么： 较大的 PR 在 review 完成前就撞到 60 分钟上限。从 #4866 拆出，让超时调整先于流水线重构独立合入。
风险： 卡死的 review 会占用自建 runner 最多 90 分钟（原 60）。范围外：#4866 的流水线重构、wait timer 数值本身。无破坏性变更。