Revert "feat(cli): enable /remember, /forget, /dream in ACP mode"#4818
Merged
Conversation
…)" This reverts commit 587bee2.
Contributor
📋 Review SummaryThis PR reverts PR #4811 which enabled 🔍 General Feedback
🎯 Specific Feedback🟡 High
🟢 Medium
🔵 Low
✅ Highlights
|
Collaborator
|
Thanks for the PR! This is a GitHub-generated revert PR — the body doesn't follow the PR template, but that's standard for reverts and the intent is clear. Not blocking on that. On direction: the revert makes sense as a workflow move. PR #4811 was merged to On approach: this is a clean revert — 6 files, +43 −278, exactly undoing the #4811 diff. Nothing to simplify. One note: the revert deletes CI is still pending (7 checks running). Will revisit after CI completes. 中文说明感谢 PR！ 这是 GitHub 自动生成的 revert PR，正文没有按照 PR 模板填写，但 revert PR 通常如此，意图很明确，不因此阻塞。 方向：revert 的原因合理——#4811 今天刚合并到 方案：干净的 revert，6 个文件，+43 −278，完全撤销 #4811 的改动。无需简化。注意：revert 删除了 CI 仍在运行中（7 个检查待完成），CI 结束后再跟进。 — Qwen Code · qwen3.7-max |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts prior work that enabled the /remember, /forget, and /dream built-in CLI commands in ACP mode, returning them to interactive-only behavior and removing ACP-specific handling/tests.
Changes:
- Remove ACP support declarations (
supportedModes: ['interactive', 'acp']) from/remember,/forget, and/dream. - Simplify
/forgetand/dreamcommand implementations by removing local try/catch wrappers and ACP-specific logic. - Remove tests that were specifically validating ACP availability/behavior (and delete the dedicated test files for
/rememberand/forget).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/cli/src/ui/commands/rememberCommand.ts | Removes ACP mode support and adjusts managed-memory prompting logic. |
| packages/cli/src/ui/commands/rememberCommand.test.ts | Deletes tests that were added for ACP enablement and related behaviors. |
| packages/cli/src/ui/commands/forgetCommand.ts | Removes ACP mode support and removes local error wrapping. |
| packages/cli/src/ui/commands/forgetCommand.test.ts | Deletes tests that were added for ACP enablement and related behaviors. |
| packages/cli/src/ui/commands/dreamCommand.ts | Removes ACP mode support and removes ACP-specific eager metadata write and local error wrapping. |
| packages/cli/src/ui/commands/dreamCommand.test.ts | Updates tests to remove ACP-specific assertions and focus on transcript directory behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
32
to
+35
| const config = context.services.config; | ||
| if (!config) { | ||
| return { | ||
| type: 'message', | ||
| messageType: 'error', | ||
| content: t('Config not loaded.'), | ||
| }; | ||
| } | ||
| const useManagedMemory = config?.getManagedAutoMemoryEnabled() ?? false; | ||
|
|
||
| if (config.getManagedAutoMemoryEnabled()) { | ||
| const memoryDir = getAutoMemoryRoot(config.getProjectRoot()); | ||
| const dirHint = ` Save it to \`${memoryDir}\`.`; | ||
| if (useManagedMemory) { |
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
yiliang114
approved these changes
Jun 6, 2026
Collaborator
✅ Local Verification Report — PR #4818Revert "feat(cli): enable /remember, /forget, /dream in ACP mode (#4811)" Environment
Build Verification
Revert IntegrityVerified that the revert produces exactly the pre-#4811 state:
Test Results
Pre-existing Failures (NOT introduced by this PR)All failures are in files not modified by this PR:
Verdict✅ PASS — Clean revert that exactly restores pre-#4811 state. The feature will be re-landed on Verified by wenshao |
wenshao
reviewed
Jun 6, 2026
wenshao
left a comment
Collaborator
There was a problem hiding this comment.
No review findings. Downgraded from Approve to Comment: CI failing: triage. — qwen3.7-max via Qwen Code /review
wenshao
reviewed
Jun 6, 2026
wenshao
left a comment
Collaborator
There was a problem hiding this comment.
No review findings. Downgraded from Approve to Comment: CI failing: triage. — qwen3.7-max via Qwen Code /review
chiga0
approved these changes
Jun 7, 2026
chiga0
left a comment
Collaborator
There was a problem hiding this comment.
Re-review at HEAD b344484 — APPROVE
PR: Revert "feat(cli): enable /remember, /forget, /dream in ACP mode" — +43/-278, 6 files, 1 commit
Clean revert of #4811. Restores pre-ACP behavior for 3 slash commands:
dreamCommand: removessupportedModes: ['interactive', 'acp'], ACP-specific eagerwriteDreamManualRun, and try/catch wrapperforgetCommand: removessupportedModesand try/catch error formattingrememberCommand: removessupportedModesand Config null guard (restoresconfig?.optional chaining withfalsedefault — pre-existing behavior)- Deletes
forgetCommand.test.tsandrememberCommand.test.ts(ACP-mode test paths), revertsdreamCommand.test.ts
yiliang114 already approved. wenshao flagged CI triage (no code findings). Copilot's config-null observation is about pre-existing behavior this revert intentionally restores.
wenshao
approved these changes
Jun 7, 2026
wenshao
reviewed
Jun 7, 2026
wenshao
left a comment
Collaborator
There was a problem hiding this comment.
No review findings. Downgraded from Approve to Comment: CI failing: triage. — qwen3.7-max via Qwen Code /review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #4811
first merge to daemon_mode_b_main branch