fix(test): raise timeout for Windows installer end-to-end tests#4352
Merged
Conversation
The Windows-only end-to-end installer tests spawn cmd.exe to run the .bat installer and then qwen.cmd --version, which boots a Node process. On GitHub's windows-latest runners that chain regularly takes >5s, so the default 5s vitest timeout makes them flaky (recently observed at 5804ms on CI). Bump the describe-block timeout to 30s, which leaves headroom without masking real regressions.
Contributor
📋 Review SummaryThis PR addresses a flaky test timeout issue on Windows CI runners by increasing the timeout from the default 5s to 30s for the Windows installer end-to-end tests. The change is minimal, well-motivated, and correctly scoped to only affect Windows-specific tests. 🔍 General Feedback
🎯 Specific Feedback🔵 Low
✅ Highlights
|
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
wenshao
commented
May 20, 2026
wenshao
left a comment
Collaborator
Author
There was a problem hiding this comment.
[Suggestion] scripts/tests/install-script.test.js:534 — The sibling describe('Linux/macOS installer end-to-end', () => { block has no timeout override, despite running structurally similar end-to-end tests that also spawn child processes via execFileSync. The PR's rationale ("CI runners are slow at spawning processes") applies to both platforms.
Consider adding a matching timeout to the Linux/macOS block (e.g. { timeout: 15000 } — no cmd.exe overhead, so less headroom needed), or setting testTimeout: 30000 in scripts/tests/vitest.config.ts to cover all E2E-style tests in this file uniformly.
— qwen-latest-series-invite-beta-v34 via Qwen Code /review
Match the timeout already applied to the Windows e2e block: the Linux/macOS installer tests also spawn child processes via execFileSync, so they share the same flake risk near the default 5s vitest timeout. 15s leaves ample headroom without Windows' cmd.exe overhead. Addresses review feedback on #4352.
Collaborator
Author
|
Thanks — addressed in 7a06517. Went with the per- |
wenshao
commented
May 20, 2026
| // These end-to-end installs spawn child processes via execFileSync; | ||
| // the default 5s vitest timeout is too tight on slow CI runners even | ||
| // without Windows' cmd.exe + node.exe startup overhead. | ||
| describe('Linux/macOS installer end-to-end', { timeout: 15000 }, () => { |
Collaborator
Author
There was a problem hiding this comment.
[Suggestion] Numeric literals 15000 / 30000 lack separators, but line 379 in this file uses 30_000. Consider 15_000 and 30_000 for intra-file consistency.
Suggested change
| describe('Linux/macOS installer end-to-end', { timeout: 15000 }, () => { | |
| describe('Linux/macOS installer end-to-end', { timeout: 15_000 }, () => { |
— qwen-latest-series-invite-beta-v34 via Qwen Code /review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/tests/install-script.test.js) spawncmd.exeto run the.batinstaller and thenqwen.cmd --version, which boots a Node process. On GitHub'swindows-latestrunners that chain regularly takes more than 5s, exceeding vitest's default 5s test timeout.installs a local standalone archive with checksum verificationtimed out at 5804ms on https://github.com/QwenLM/qwen-code/actions/runs/26139062779/job/76880493669 (a PR unrelated to the installer).{ timeout: 30000 }on theWindows installer end-to-enddescribeblock. The timeout cascades to all threeitOnWindowstests inside it; no behavior change other than headroom on slow Windows runners.Test plan
itOnWindows(no behavior change).Test (windows-latest, Node 22.x)) passes — please re-check this on the green run.