fix(test): clear boundedPromise timers to prevent unhandled rejections in abort-and-lifecycle test#4220
Merged
Conversation
boundedPromise timeouts could fire after test completion, causing vitest to exit with code 1 due to unhandled rejection. Add clear() method and cleanup all pending timers in the finally block.
Contributor
📋 Review SummaryThis PR addresses a CI E2E test failure caused by dangling 🔍 General Feedback
🎯 Specific Feedback🔵 Low
✅ Highlights
|
wenshao
commented
May 17, 2026
wenshao
left a comment
Collaborator
Author
There was a problem hiding this comment.
No review findings. Downgraded from Approve to Comment: self-PR; CI still running. — gpt-5.5 via Qwen Code /review
pomelo-nwu
approved these changes
May 17, 2026
pomelo-nwu
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. The timer cleanup is scoped to the test harness and preserves the existing behavioral assertions. Please wait for the remaining Windows CI check to pass before merging.
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
wenshao
commented
May 17, 2026
wenshao
left a comment
Collaborator
Author
There was a problem hiding this comment.
No issues found. The fix is clean and correctly addresses the unhandled-rejection root cause:
timer = undefinedset afterclearTimeoutin both resolve and timeout paths prevents double-clear and stale timer references- New
clear()method encapsulates safe timer teardown pendingTimersarray covers all four bounded promises used in the testfinallyblock clears timers beforeq.close(), ensuring no dangling callbacks fire after test completion
— glm-5.1 via Qwen Code /review
xaelistic
pushed a commit
to xaelistic/qwen-code
that referenced
this pull request
Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
boundedPromiseinabort-and-lifecycle.test.tsto prevent danglingsetTimeoutcallbacks from firing after test completion.secondResult timeout after 30000ms. All tests passed but the leftover timer triggered vitest's unhandled error detection.boundedPromisenow returns aclear()method; all four bounded promises are collected inpendingTimersand cleared in thefinallyblock beforeq.close().Validation
# Local syntax check (pre-commit hook passes) npm run buildsecondResulttimer firing after the test body completed, producingUnhandled Rejection→ exit code 1.clear()properly callsclearTimeoutand thatpendingTimerscovers all four bounded promises used in the test.Scope / Risk
boundedPromise.Testing Matrix
Testing matrix notes:
Linked Issues / Bugs
No linked issues.
🤖 Generated with Qwen Code