ci(release): keep skip-ci out of release PR titles#3950
Conversation
|
@copilot pls review it |
The changes look correct and well-scoped. Here's the review: What changed:
Why it's correct:
Validation:
LGTM — the change is minimal, accurate, and removes a misleading artifact from the PR metadata without affecting the actual CI-skip mechanism. |
There was a problem hiding this comment.
Pull request overview
Removes [skip ci] from auto-generated release PR titles so PR metadata doesn’t imply CI-skipping behavior, while keeping [skip ci] explicitly on the squash merge subject that lands on main to avoid redundant post-merge CI.
Changes:
- Update
gh pr create --titlein release workflows to omit[skip ci]. - Update nearby comments to clarify that
[skip ci]is intentionally limited to the squash commit subject (gh pr merge --subject ... [skip ci]).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/release.yml | Removes [skip ci] from the release PR title while keeping it on the squash merge subject; updates explanatory comments. |
| .github/workflows/release-sdk.yml | Same adjustment for the SDK release PR title; keeps [skip ci] on the squash merge subject and updates comments. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
|
Here is the release flow this PR is trying to make explicit, using the real flowchart TD
A["Release workflow runs for v0.15.8"] --> B["Create release branch: release/v0.15.8"]
B --> C["Commit version files on release branch: chore(release): v0.15.8"]
C --> D["Create GitHub Release and tag v0.15.8"]
D --> E["Create version-sync PR into main"]
E --> F["Maintainer approves the PR"]
F --> G["Auto-merge squashes PR into main: chore(release): v0.15.8 (#3928) [skip ci]"]
G --> H["Skip duplicate main-push CI for version-file sync"]
Concrete links from the existing
So the intended responsibility split is:
This PR keeps that behavior while removing the misleading One intentional detail: the release branch commit / PR head commit does not include The release workflow creates the GitHub release tag before opening the version-sync PR, and the tag points at that release branch commit via If we want to skip the unnecessary CI on the version-sync PR itself, the better follow-up is to add explicit |
Summary
[skip ci]from the auto-generated release PR titles inrelease.ymlandrelease-sdk.yml, while keeping[skip ci]on the explicit squash merge subject that lands onmain.gh pr merge --subject "... [skip ci]"still skips the duplicate post-merge main push CI.Validation
[skip ci]; the squash merge subject still includes[skip ci]for the main-branch version sync commit.[skip ci]remains only in the squash--subjectplus the explanatory comments.gh pr create --titlelines in both release workflows.gh pr merge --subjectlines still include[skip ci].Scope / Risk
[skip ci], so main-push workflows triggered by that version-sync commit remain skipped by design.Testing Matrix
Testing matrix notes:
Linked Issues / Bugs
Related follow-up to #3912.