feat(cli): add remote-control worker server by chiga0 · Pull Request #3930 · QwenLM/qwen-code

chiga0 · 2026-05-07T16:56:46Z

Summary

This is PR 2 of the 3-PR stacked remote-control implementation. It is stacked on #3929.

Stack split:

Foundation (feat(cli): add remote-control foundation #3929): design doc plus stream-json interrupt/session lifecycle fixes.
Worker server (this PR, feat(cli): add remote-control worker server #3930): local HTTP/WebSocket remote-control server, pairing/auth, event replay, worker session runner, command routing, LAN URL reporting, and minimal browser/mobile UI.
Current TUI attach (feat(cli): attach remote-control to current TUI #3931): attach the live Ink TUI to the same server via dual-output and remote-input bridges.

This PR adds the first usable remote-control mode: qwen remote-control. Remote clients can pair, create worker sessions, submit prompts, replay history, approve/deny tools, interrupt turns, switch model, switch permission mode, and query context usage through the stream-json control plane.

Security / mobile notes

Binds to 127.0.0.1 by default.
Refuses non-loopback binds unless --allow-lan is explicit.
Reports LAN URLs when LAN mode is enabled, so mobile devices do not have to guess the host address.
Uses one-time pairing token plus issued client tokens; raw tokens are not stored.
Enforces max payload, max clients, origin checks, auth failure rate limiting, and CSP for static UI.

Validation

cd packages/cli && npm run typecheck
cd packages/cli && npx vitest run src/remoteControl/EventLog.test.ts src/remoteControl/PairingManager.test.ts src/remoteControl/RemoteSessionRunner.test.ts src/remoteControl/RemoteControlServer.test.ts
git diff --check feat/remote-control...feat/remote-control-worker

wenshao

Missing test coverage: SessionRegistry.ts (311 lines, core state machine) has no test file. protocol.ts (parseRemoteEnvelope, requireStringField — security boundary parsing) has no test file. RemoteControlServer.test.ts covers only 3 scenarios for 673 lines of server code.

wenshao · 2026-05-15T02:46:46Z

+      if (
+        state.authenticated &&
+        (state.subscriptions.has(sessionId) ||
+          envelope.type === 'session/state')


[Critical] broadcast() sends session/state events to all authenticated clients regardless of their subscription to that session — the condition envelope.type === 'session/state' bypasses state.subscriptions.has(sessionId). In --allow-lan mode, this leaks session metadata (cwd, model, permissionMode) across potentially different users.

Suggested change

envelope.type === 'session/state')

private broadcast(sessionId: string, envelope: RemoteEnvelope): void {

for (const [ws, state] of this.clients.entries()) {

if (state.authenticated && state.subscriptions.has(sessionId)) {

this.sendEnvelope(ws, envelope);

}

}

}

— DeepSeek/deepseek-v4-pro via Qwen Code /review

wenshao · 2026-05-15T02:46:46Z

+    return requestId;
+  }
+
+  private sendJson(value: unknown): void {


[Critical] sendJson() writes to child.stdin without checking the return value, without a drain listener, and without an error handler on the stdin stream. Six code paths (submit, respondToTool, interrupt, setModel, setPermissionMode, getContextUsage) all call sendJson. An EPIPE (child exited) or backpressure condition silently drops data — the remote client receives command/ack before the write actually succeeds.

Suggested change

private sendJson(value: unknown): void {

private sendJson(value: unknown): void {

if (!this.child || this.closed) {

throw new Error('Remote session runner is not running');

}

try {

const ok = this.child.stdin.write(`${JSON.stringify(value)}\n`);

if (!ok) {

// backpressure: consider waiting for drain before ack

this.child.stdin.once('drain', () => { /* ack after drain */ });

}

} catch (err) {

this.closed = true;

this.options.onError?.(err as Error);

throw err;

}

}

— DeepSeek/deepseek-v4-pro via Qwen Code /review

wenshao · 2026-05-15T02:46:46Z

+    }
+    const valid = this.safeEquals(this.pairingToken.hash, this.hash(token));
+    if (valid) {
+      this.pairingToken = null;


[Critical] verifyPairingToken immediately sets this.pairingToken = null upon successful validation, consuming the one-time token. If the WebSocket drops between auth/pair validation and the auth/result response (lines 34-40), the client never receives the clientToken and is permanently locked out — the pairing token is already consumed. This requires a server restart to recover.

Suggested change

this.pairingToken = null;

// Defer token invalidation until auth/result is confirmed sent:

// In RemoteControlServer.handleAuth, set pairingToken = null only after

// sendEnvelope(ws, makeEnvelope('auth/result', { clientToken, ... })) succeeds.

— DeepSeek/deepseek-v4-pro via Qwen Code /review

wenshao · 2026-05-15T02:46:46Z

+    return event;
+  }
+
+  replay(since?: number): EventLogReplay {


[Critical] replay() without a since argument always returns truncated: false (line 47), even when the ring buffer has evicted older events (line 39-40). A client requesting full history gets silently truncated data and believes it has the complete event stream.

Suggested change

replay(since?: number): EventLogReplay {

replay(since?: number): EventLogReplay {

if (since === undefined) {

const truncated = this.events.length >= this.limit && this.nextSeq > this.limit;

return { events: [...this.events], truncated };

}

// ...

}

— DeepSeek/deepseek-v4-pro via Qwen Code /review

wenshao · 2026-05-15T02:46:47Z

+    return this.getRecord(sessionId).log.replay(since);
+  }
+
+  submit(sessionId: string, text: string): void {


[Critical] Session operations (submit, respondToTool, interrupt, setModel, setPermissionMode, getContextUsage) delegate directly to the runner without checking the session's current state. A closed or errored session's runner may throw (sendJson guards against this.closed), but the error is caught generically in RemoteControlServer.handleWsMessage without including the sessionId in the error response, making debugging extremely difficult.

Suggested change

submit(sessionId: string, text: string): void {

// In each mutating method, guard on state first:

submit(sessionId: string, text: string): void {

const record = this.getRecord(sessionId);

if (record.snapshot.state === 'closed' || record.snapshot.state === 'error') {

throw new Error(`Cannot submit: session ${sessionId} is ${record.snapshot.state}`);

}

record.runner.submit(text);

this.setState(sessionId, 'working');

this.append(sessionId, 'user/submit', { text });

}

— DeepSeek/deepseek-v4-pro via Qwen Code /review

wenshao · 2026-05-15T02:46:47Z

+    }
+
+    const firstSeq = this.events[0]?.seq;
+    const truncated = firstSeq !== undefined && since < firstSeq - 1;


[Suggestion] replay(since) returns truncated: false when the event log is empty but since > 0. When this.events is empty, firstSeq is undefined, making truncated evaluate to false regardless of since's value. A reconnecting client receives { events: [], truncated: false }, which is indistinguishable from a genuinely empty log (vs. all events evicted).

— DeepSeek/deepseek-v4-pro via Qwen Code /review

wenshao · 2026-05-15T02:46:47Z

+        this.append(id, 'event/append', { childExit: details });
+        this.setState(id, 'closed');
+      },
+      onError: (error) => {


[Suggestion] The onError callback in createSession unconditionally calls this.setState(id, 'error', error.message). If the child process triggers an error after closeSession() has set state to 'closed', the state reverts from 'closed' to 'error', violating the state machine invariant. Add a guard: skip setState when current state is 'closed'.

— DeepSeek/deepseek-v4-pro via Qwen Code /review

wenshao · 2026-05-15T02:46:47Z

+      crlfDelay: Infinity,
+    });
+
+    this.stdoutReader.on('line', (line) => this.handleStdoutLine(line));


[Suggestion] When the child process exits, onExit sets this.closed = true but does not close this.stdoutReader. Buffered stdout lines can still trigger handleStdoutLine → handleChildMessage, which can transition state back to 'idle' or 'working', corrupting the 'closed' terminal state. Add this.stdoutReader?.close() in onExit or a if (this.closed) return; guard in handleStdoutLine.

— DeepSeek/deepseek-v4-pro via Qwen Code /review

wenshao · 2026-05-15T02:46:47Z

+    this.wss = null;
+  }
+
+  getInfo(): RemoteControlServerInfo {


[Suggestion] getInfo() returns this.pairingToken indefinitely, even after PairingManager.verifyPairingToken() has consumed the internal pairing record. After a successful pairing, getInfo() and the /api/pairing endpoint still report the original token value, misleading clients into believing a valid pairing token exists. Clear this.pairingToken after the first successful authentication.

— DeepSeek/deepseek-v4-pro via Qwen Code /review

wenshao · 2026-05-15T02:46:47Z

+      );
+    }
+
+    const shutdown = async () => {


[Suggestion] The SIGINT/SIGTERM shutdown handler uses void shutdown() where shutdown contains await server.stop(); process.exit(0). If server.stop() throws, the promise rejection is unhandled (due to void), and process.exit(0) never executes — the process hangs indefinitely on await new Promise<void>(() => {}). Wrap shutdown in try/catch with process.exit(1) on error.

— DeepSeek/deepseek-v4-pro via Qwen Code /review

chiga0 · 2026-05-15T09:25:32Z

Closing for now — deprioritized while the daemon PRs (#3889 et al.) land. The remote-control surface will be reconsidered after the daemon layer stabilizes; reopening this stack would need a rebase on the new daemon foundation anyway. Branch preserved for later resurrection.

This was referenced May 7, 2026

feat(cli): attach remote-control to current TUI #3931

Closed

feat(cli): add remote-control foundation #3929

Closed

github-actions Bot mentioned this pull request May 8, 2026

📊 AI CLI 工具社区动态日报 2026-05-08 zx0828/big_model_radar#43

Open

chiga0 force-pushed the feat/remote-control-worker branch from 3bac087 to fc1692b Compare May 8, 2026 01:28

chiga0 force-pushed the feat/remote-control branch from c2731ad to ca5b8e0 Compare May 8, 2026 01:28

github-actions Bot mentioned this pull request May 8, 2026

📊 AI CLI 工具社区动态日报 2026-05-08 gsscsd/big_model_radar#310

Open

feat(cli): add remote-control foundation

267c3d2

chiga0 force-pushed the feat/remote-control branch from ca5b8e0 to 267c3d2 Compare May 8, 2026 02:08

chiga0 force-pushed the feat/remote-control-worker branch 2 times, most recently from 593cf8d to cf5f16e Compare May 8, 2026 02:34

秦奇 added 2 commits May 8, 2026 13:07

docs: expand remote-control product integration design

9d30917

feat(cli): add remote-control worker server

8b62124

chiga0 force-pushed the feat/remote-control-worker branch from cf5f16e to 8b62124 Compare May 8, 2026 05:08

This was referenced May 11, 2026

Daemon mode (qwen serve): proposal & open decisions #3803

Open

feat(cli,sdk): qwen serve daemon (Stage 1) #3889

Merged

chiga0 force-pushed the feat/remote-control branch from 9d30917 to 8c15016 Compare May 14, 2026 08:28

doudouOUC mentioned this pull request May 14, 2026

proposal(serve): qwen --serve (Mode A) — TUI + in-process HTTP daemon, 3-phase plan (Stage 1.5b) #4156

Open

22 tasks

wenshao requested changes May 15, 2026

View reviewed changes

chiga0 closed this May 15, 2026

doudouOUC mentioned this pull request May 15, 2026

proposal(serve): Mode B feature-priority roadmap toward v0.16 production-ready #4175

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(cli): add remote-control worker server#3930

feat(cli): add remote-control worker server#3930
chiga0 wants to merge 3 commits into
feat/remote-controlfrom
feat/remote-control-worker

chiga0 commented May 7, 2026 •

edited

Loading

Uh oh!

wenshao left a comment

Uh oh!

wenshao May 15, 2026

Uh oh!

wenshao May 15, 2026

Uh oh!

wenshao May 15, 2026

Uh oh!

wenshao May 15, 2026

Uh oh!

wenshao May 15, 2026

Uh oh!

wenshao May 15, 2026

Uh oh!

wenshao May 15, 2026

Uh oh!

wenshao May 15, 2026

Uh oh!

wenshao May 15, 2026

Uh oh!

wenshao May 15, 2026

Uh oh!

chiga0 commented May 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-          envelope.type === 'session/state')
+private broadcast(sessionId: string, envelope: RemoteEnvelope): void {
+    for (const [ws, state] of this.clients.entries()) {
+      if (state.authenticated && state.subscriptions.has(sessionId)) {
+        this.sendEnvelope(ws, envelope);
+      }
+    }
+  }

-  private sendJson(value: unknown): void {
+private sendJson(value: unknown): void {
+    if (!this.child || this.closed) {
+      throw new Error('Remote session runner is not running');
+    }
+    try {
+      const ok = this.child.stdin.write(`${JSON.stringify(value)}\n`);
+      if (!ok) {
+        // backpressure: consider waiting for drain before ack
+        this.child.stdin.once('drain', () => { /* ack after drain */ });
+      }
+    } catch (err) {
+      this.closed = true;
+      this.options.onError?.(err as Error);
+      throw err;
+    }
+  }

-      this.pairingToken = null;
+// Defer token invalidation until auth/result is confirmed sent:
+// In RemoteControlServer.handleAuth, set pairingToken = null only after
+// sendEnvelope(ws, makeEnvelope('auth/result', { clientToken, ... })) succeeds.

-  replay(since?: number): EventLogReplay {
+replay(since?: number): EventLogReplay {
+    if (since === undefined) {
+      const truncated = this.events.length >= this.limit && this.nextSeq > this.limit;
+      return { events: [...this.events], truncated };
+    }
+    // ...
+  }

-  submit(sessionId: string, text: string): void {
+// In each mutating method, guard on state first:
+submit(sessionId: string, text: string): void {
+    const record = this.getRecord(sessionId);
+    if (record.snapshot.state === 'closed' || record.snapshot.state === 'error') {
+      throw new Error(`Cannot submit: session ${sessionId} is ${record.snapshot.state}`);
+    }
+    record.runner.submit(text);
+    this.setState(sessionId, 'working');
+    this.append(sessionId, 'user/submit', { text });
+  }

Conversation

chiga0 commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Security / mobile notes

Validation

Uh oh!

wenshao left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chiga0 commented May 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

chiga0 commented May 7, 2026 •

edited

Loading