fix(review): respect /language output setting for local reviews#3611
Merged
Conversation
The /review skill's language rule "match the language of the PR" has no applicable target during local reviews (no PR exists). When a user sets an output language via /language, local review output now honors that preference instead of defaulting to English. PR reviews remain unchanged — they continue matching the PR's language since findings may be published as inline comments visible to all collaborators. Closes #3594
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
wenshao
approved these changes
Apr 25, 2026
wenshao
left a comment
Collaborator
There was a problem hiding this comment.
No issues found. LGTM! ✅ — gpt-5.5 via Qwen Code /review
xaelistic
pushed a commit
to xaelistic/qwen-code
that referenced
this pull request
Jun 7, 2026
…LM#3611) Co-authored-by: Jacob Richman <jacob314@gmail.com> Co-authored-by: Allen Hutchison <adh@google.com>
xaelistic
pushed a commit
to xaelistic/qwen-code
that referenced
this pull request
Jun 7, 2026
…LM#3611) The /review skill's language rule "match the language of the PR" has no applicable target during local reviews (no PR exists). When a user sets an output language via /language, local review output now honors that preference instead of defaulting to English. PR reviews remain unchanged — they continue matching the PR's language since findings may be published as inline comments visible to all collaborators. Closes QwenLM#3594
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
The
/reviewskill's language rule "match the language of the PR" now falls back to the user's/language outputpreference during local reviews (no PR target). PR review behavior is unchanged.Dive Deeper
The
/reviewskill enforces a language rule: "Match the language of the PR." This works well for PR reviews — findings may be published as inline comments via--comment, so matching the PR's language ensures readability for all collaborators.However, during local reviews (
/reviewwith no arguments, reviewing uncommitted changes), there is no PR to match. The skill instructions are entirely in English, so the LLM defaults to English output — ignoring any/language outputpreference the user has configured.This change adds a fallback clause to both the critical rules (line 20) and guidelines (line 531):
/language output), use that language for local review outputReviewer Test Plan
/language output 中文, run/review(no args, with local changes) → terminal output should be in Chinese/language output ru, run/review(no args) → terminal output should be in Russian/review 123(PR review) → behavior unchanged, still matches PR languageTesting Matrix
Linked issues / bugs
Closes #3594