fix(sdk-java): pass custom env to CLI process#3543
Merged
Conversation
wenshao
approved these changes
Apr 24, 2026
wenshao
left a comment
Collaborator
There was a problem hiding this comment.
No issues found. LGTM! ✅ — gpt-5.4 via Qwen Code /review
xaelistic
pushed a commit
to xaelistic/qwen-code
that referenced
this pull request
Jun 7, 2026
Co-authored-by: lawrence3699 <lawrence3699@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Fixes #3536.
Apply
TransportOptions.setEnv(...)to the Java SDKProcessBuilderbefore starting the Qwen Code CLI subprocess. The adapter already mergesSystem.getenv()with the caller-provided env map, but the merged map was never wired into the child process.Screenshots / Video Demo
Terminal evidence:
Before this change, the focused regression failed because the child process printed an empty value:
expected: <from-set-env> but was: <>After this change:
Dive Deeper
TransportOptionsAdapter#addDefaultTransportOptions()already builds the intended subprocess environment by starting fromSystem.getenv()and overlayingTransportOptions.getEnv().ProcessTransport#start()now copies that handled env map intoprocessBuilder.environment()beforestart(), so Java SDK callers can pass values such as proxy, sandbox, model, or other runtime configuration variables to the CLI process as documented.Reviewer Test Plan
packages/sdk-java/qwencode, runmvn -Dtest=ProcessTransportTest#shouldPassCustomEnvToProcess test.QWEN_SDK_TEST_ENVthroughTransportOptions.setEnv(...), and reads the value from the child process output.ProcessTransport#start()and confirm the handled env map is applied beforeprocessBuilder.start().Testing Matrix
Java SDK validation run on macOS:
All passed. I did not run
npm run preflight; this patch is limited to the Maven-based Java SDK package, and the existing package test file includes live-CLI tests that can depend on local auth/provider state.Linked issues / bugs
Fixes #3536