Skip to content

fix: add --fast hint to /model description for discoverability#3086

Merged
tanzhenxin merged 1 commit into
QwenLM:mainfrom
wenshao:fix/model-fast-discoverability
Apr 10, 2026
Merged

fix: add --fast hint to /model description for discoverability#3086
tanzhenxin merged 1 commit into
QwenLM:mainfrom
wenshao:fix/model-fast-discoverability

Conversation

@wenshao

@wenshao wenshao commented Apr 10, 2026

Copy link
Copy Markdown
Collaborator

Motivation

#3077--fast 补全改为仅在用户输入 - 后才显示,防止了 Tab+Enter 误触。但这也意味着用户在 /model 命令列表中无法发现 --fast 功能的存在。

After #3077 changed --fast completion to only appear when the user starts typing -, users have no way to discover the --fast feature from the command list.

Changes

Add (--fast for suggestion model) hint to /model command description, so users can discover the feature when browsing the command list.

Before After
Switch the model for this session Switch the model for this session (--fast for suggestion model)

Uploading image.png…

Test plan

  • modelCommand.test.ts — 8/8 passed

🤖 Generated with Claude Code

Add "(--fast for suggestion model)" to the /model command description
so users can discover the feature from the command list, since --fast
completion no longer appears on empty input.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

📋 Review Summary

This PR restores the (--fast for suggestion model) hint in the /model command description across all source files and 6 i18n locales. The change is a straightforward fix to address a merge conflict resolution that accidentally removed this important discoverability hint. The implementation is consistent and well-tested.

🔍 General Feedback

  • Consistency: The change is applied uniformly across all 8 files (6 locale files, 1 source file, 1 test file), maintaining proper synchronization between code and translations.
  • Scope: Appropriate scope for a fix PR—focused solely on restoring the missing hint without introducing unrelated changes.
  • Test coverage: The test file is updated to match the new expected description, ensuring the change is verified.
  • Translation quality: All locale translations appear to appropriately convey the --fast hint in their respective languages.

🎯 Specific Feedback

🔵 Low

  • File: packages/cli/src/i18n/locales/en.js:1154 - The English locale file now has a redundant key-value pair where the key and value are identical:
    'Switch the model for this session (--fast for suggestion model)':
      'Switch the model for this session (--fast for suggestion model)',
    Consider using a variable or comment to indicate this is the source string, though this is a minor stylistic point and follows the existing i18n pattern used elsewhere in the file.

✅ Highlights

  • Quick fix for UX regression: This promptly addresses a user experience regression where the --fast feature discovery was broken.
  • Comprehensive coverage: All 6 locales (de, en, ja, pt, ru, zh) are updated consistently.
  • Test alignment: The test file is properly updated to validate the new description.
  • Clear PR description: The motivation and changes are well-documented with before/after comparison.

@tanzhenxin tanzhenxin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Adds (--fast for suggestion model) hint to /model command description for discoverability after #3077 hid the --fast completion behind - prefix. All 6 i18n locales updated.

Verdict

APPROVE — Clean, focused discoverability fix. No issues.

@tanzhenxin tanzhenxin merged commit 520f1e2 into QwenLM:main Apr 10, 2026
14 checks passed
euxaristia pushed a commit to euxaristia/qwen-code that referenced this pull request Apr 10, 2026
…M#3086)

Add "(--fast for suggestion model)" to the /model command description
so users can discover the feature from the command list, since --fast
completion no longer appears on empty input.

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
xaelistic pushed a commit to xaelistic/qwen-code that referenced this pull request Jun 7, 2026
xaelistic pushed a commit to xaelistic/qwen-code that referenced this pull request Jun 7, 2026
…M#3086)

Add "(--fast for suggestion model)" to the /model command description
so users can discover the feature from the command list, since --fast
completion no longer appears on empty input.

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants