feat: add build-binary target to Makefile and implement build script for multiple platforms#302
feat: add build-binary target to Makefile and implement build script for multiple platforms#3022niuhe wants to merge 24 commits into
Conversation
…for multiple platforms
Co-authored-by: Taylor Mullen <ntaylormullen@google.com>
- Replace 'tiktoken' with '*.wasm' in esbuild external dependencies. - Add logic to handle different execution environments (Node vs Bun) in relaunchAppInChildProcess. - Update Bun build command to version 1.3.4. - Implement copying of tiktoken wasm file to the distribution directory.
Resolved conflict in esbuild.config.js by keeping '*.wasm' in external array Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
DragonnZhang
left a comment
There was a problem hiding this comment.
LGTM! ✅ Clean implementation of binary build targets. The relaunch.ts changes properly handle compiled binary execution vs interpreter mode. Minor note: bun@1.3.4 is hardcoded in build_bun_binary.js — consider using a configurable version in a follow-up. — Qwen Code /review
Co-authored-by: Taylor Mullen <ntaylormullen@google.com>
|
Thanks for this, @2niuhe, and apologies for the long delay in review. Since this was opened, #3776 shipped standalone archive installation, which addresses the core goal here — running Qwen Code without a local Node.js/npm install — by bundling the official Node.js runtime. That PR intentionally chose the standalone-archive route over the Bun single-file executable, noting the Bun path still needs a separate compatibility pass (runtime assets, optional native deps, Node API behavior, release artifacts/checksums, installer integration). Given that, I'm closing this PR for now to keep the queue focused. The Bun/SEA direction is still worthwhile, and the installer/release infrastructure from #3776 should be reusable when someone picks up that compatibility pass. Happy to revisit a fresh PR scoped to that. Thanks again for kicking this off! 🙏 |
TLDR
use bun to build single executable application.
Testing Matrix
Linked issues / bugs