fix(core): coerce string boolean values in schema validation#1284
Merged
Conversation
Self-hosted LLMs sometimes return "true"/"false" strings instead of actual boolean values for tool parameters like `is_background`. This causes schema validation to fail with type errors. Fixes #1267
Collaborator
|
LGTM! |
xaelistic
pushed a commit
to xaelistic/qwen-code
that referenced
this pull request
Jun 7, 2026
xaelistic
pushed a commit
to xaelistic/qwen-code
that referenced
this pull request
Jun 7, 2026
fix(core): coerce string boolean values in schema validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
When using self-hosted LLMs (like Ollama), the shell tool sometimes fails because the model returns
"true"instead oftrueforis_background. This PR makes the schema validator smarter about handling that.Dive Deeper
The existing code already had a
fixBooleanCasingfunction that handled"True"→"true"case normalization, but it didn't actually convert strings to booleans.I renamed it to
fixBooleanValuesand made it convert:"true"/"True"/"TRUE"→true"false"/"False"/"FALSE"→falseThis is a global fix so any tool with boolean params benefits, not just ShellTool.
Added tests for both the schema validator and shell tool to cover the new behavior.
Linked issues / bugs
Fixes #1267