mcp config as cli#1279
Conversation
wenshao
left a comment
There was a problem hiding this comment.
No issues found. LGTM! ✅ — gpt-5.4 via Qwen Code /review
|
Hi @eliird — this PR currently has merge conflicts with |
|
Will do |
9adc6ee to
38b2a74
Compare
|
Hi, during the rebase I had to make a few additional adjustments to fit the current codebase — wanted to be transparent about what changed:
@wenshao could you take a look at it when you have time? |
wenshao
left a comment
There was a problem hiding this comment.
No issues found. LGTM! ✅ — gpt-5.5 via Qwen Code /review
|
@eliird Thanks for the contribution! This PR is currently showing merge conflicts. Could you please rebase or merge the latest |
|
Thanks for the work — the implementation reads cleanly and the test coverage hits the key paths (wrapper, no-wrapper, override, allow-list filter, empty). Two items before this can land: 1. Rebase required (blocker)The branch conflicts with current
2. Nice-to-haves on
|
|
@wenshao Sorry, I have been busy last week and was not able to respond. I will rebase it today. |
662dafc to
57ee7c9
Compare
|
@wenshao I rebased the main. Can you take a look at it when you have time. |
wenshao
left a comment
There was a problem hiding this comment.
No issues found. LGTM! ✅ — gpt-5.5 via Qwen Code /review
|
Thanks @eliird — merged in 8896f93. The two small UX nits I flagged earlier were non-blocking, but worth a follow-up PR when you have time:
No rush — happy to review whenever you get to it. |
* mcp config as cli * fix: failed test cases * updated tests to match the new api * fix: update mcp-config tests for new API and fix type import * mcp config type declared handler.ts --------- Co-authored-by: Ird <irdali.durrani@fixstars.com> Co-authored-by: mingholy.lmh <mingholy.lmh@alibaba-inc.com>
mcp server config passed as flag.
Dive Deeper
Reviewer Test Plan
Testing Matrix
Linked issues / bugs