Add matchers for Result that match against submatchers, or for equatable values.#1134
Merged
Add matchers for Result that match against submatchers, or for equatable values.#1134
Conversation
cgrindel-self-hosted-renovate bot
referenced
this pull request
in cgrindel/rules_swift_package_manager
Apr 9, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [Quick/Nimble](https://togithub.com/Quick/Nimble) | minor | `from: "13.2.1"` -> `from: "13.3.0"` | --- ### Release Notes <details> <summary>Quick/Nimble (Quick/Nimble)</summary> ### [`v13.3.0`](https://togithub.com/Quick/Nimble/releases/tag/v13.3.0) [Compare Source](https://togithub.com/Quick/Nimble/compare/v13.2.1...v13.3.0) ### Highlights - Adds Matchers for Result that match against submatchers or equatable values. - Use DocC for documentation. - Make `PollingDefaults` threadsafe. #### What's Changed - Make PollingDefaults threadsafe by [@​younata](https://togithub.com/younata) in [https://github.com/Quick/Nimble/pull/1122](https://togithub.com/Quick/Nimble/pull/1122) - Bump softprops/action-gh-release from 1 to 2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/Quick/Nimble/pull/1128](https://togithub.com/Quick/Nimble/pull/1128) - Depend on CwlPreconditionTesting 2.2.0 for Cocoapods by [@​younata](https://togithub.com/younata) in [https://github.com/Quick/Nimble/pull/1129](https://togithub.com/Quick/Nimble/pull/1129) - Add matchers for Result that match against submatchers, or for equatable values. by [@​younata](https://togithub.com/younata) in [https://github.com/Quick/Nimble/pull/1134](https://togithub.com/Quick/Nimble/pull/1134) - Use docc for documentation, instead of having it all in a single, giant README. by [@​younata](https://togithub.com/younata) in [https://github.com/Quick/Nimble/pull/1135](https://togithub.com/Quick/Nimble/pull/1135) - Get documentation deploying working. by [@​younata](https://togithub.com/younata) in [https://github.com/Quick/Nimble/pull/1136](https://togithub.com/Quick/Nimble/pull/1136) - Improve documentation articles by adding short abstracts to them. by [@​younata](https://togithub.com/younata) in [https://github.com/Quick/Nimble/pull/1137](https://togithub.com/Quick/Nimble/pull/1137) - Fix a typo in the name of this framework. 🤦🏻♀️ by [@​younata](https://togithub.com/younata) in [https://github.com/Quick/Nimble/pull/1138](https://togithub.com/Quick/Nimble/pull/1138) - Bump actions/checkout from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/Quick/Nimble/pull/1139](https://togithub.com/Quick/Nimble/pull/1139) **Full Changelog**: Quick/Nimble@v13.2.1...v13.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
noamfreeman
pushed a commit
to noamfreeman/Nimble
that referenced
this pull request
Oct 14, 2024
…ble values. (Quick#1134) * Add matchers for Result that match against submatchers, or for equatable values. * Add documentation for the new matchers for result
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I find that the current matchers for Result, where you must pass in a closure to be checked against the success/failure values, to be rather cumbersome. I'd much rather pass in another matcher to do this check. I find that it reads much easier.
To that end, I added
beSuccessthat takes in a matcher, andbeFailurethat takes in a matcher.For additional ease of use, I also added
beSuccessthat takes in an Equatable value, for when the success value is Equatable itself. This is similar to usingbeSuccess(equal(someValue)), but it also slightly improves the error message in that case.New feature: Minor version bump required!