Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## master #222 +/- ##
==========================================
- Coverage 71.25% 71.21% -0.04%
==========================================
Files 2 2
Lines 240 264 +24
==========================================
+ Hits 171 188 +17
- Misses 69 76 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mmcky
added a commit
that referenced
this pull request
Feb 19, 2026
Complete rewrite of the dark theme for a modern, consistent, and readable dark mode experience. Color palette: - Replace ad-hoc grays (#222/#333/#444) with a cohesive navy-charcoal palette - Body background: #1a1a2e, Surfaces: #252540/#2d2d4a - Text: #d4d4e4 (soft white, reduces eye strain vs pure #fff) - Links: #6cb6ff (distinguishable from body text) - Borders: #3a3a5c (subtle, consistent) Syntax highlighting: - Add complete dark mode token colors for all ~40 syntax classes - VS Code Dark+ inspired palette - Previously only 3 of ~40 tokens had dark overrides Bug fixes: - Fix table row text color (#333 on dark bg was unreadable) - Fix links being indistinguishable from body text (all were #fff) - Fix inline code having light border on dark background - Fix sidebar search area remaining white in dark mode - Fix toolbar border remaining light gray - Fix image inversion being too aggressive (now uses subtle opacity) New dark mode coverage: - Modals, admonitions (type-specific accents), homepage elements - Collapse/toggle bars, tooltips, anchor links, autodoc, footnotes - Non-QuantEcon project color overrides, toctree caption text UX improvements: - Eliminate FOUC with early dark mode injection script - SVG icons use currentColor instead of forced white - Images use subtle opacity reduction instead of aggressive inversion - Stderr warnings updated to match new palette
mmcky
added a commit
that referenced
this pull request
Feb 19, 2026
Complete rewrite of the dark theme for a modern, consistent, and readable dark mode experience. Color palette: - Replace ad-hoc grays (#222/#333/#444) with a cohesive navy-charcoal palette - Body background: #1a1a2e, Surfaces: #252540/#2d2d4a - Text: #d4d4e4 (soft white, reduces eye strain vs pure #fff) - Links: #6cb6ff (distinguishable from body text) - Borders: #3a3a5c (subtle, consistent) Syntax highlighting: - Add complete dark mode token colors for all ~40 syntax classes - VS Code Dark+ inspired palette - Previously only 3 of ~40 tokens had dark overrides Bug fixes: - Fix table row text color (#333 on dark bg was unreadable) - Fix links being indistinguishable from body text (all were #fff) - Fix inline code having light border on dark background - Fix sidebar search area remaining white in dark mode - Fix toolbar border remaining light gray - Fix image inversion being too aggressive (now uses subtle opacity) New dark mode coverage: - Modals, admonitions (type-specific accents), homepage elements - Collapse/toggle bars, tooltips, anchor links, autodoc, footnotes - Non-QuantEcon project color overrides, toctree caption text UX improvements: - Eliminate FOUC with early dark mode injection script - SVG icons use currentColor instead of forced white - Images use subtle opacity reduction instead of aggressive inversion - Stderr warnings updated to match new palette
mmcky
added a commit
that referenced
this pull request
Feb 23, 2026
* feat: comprehensive dark theme overhaul Complete rewrite of the dark theme for a modern, consistent, and readable dark mode experience. Color palette: - Replace ad-hoc grays (#222/#333/#444) with a cohesive navy-charcoal palette - Body background: #1a1a2e, Surfaces: #252540/#2d2d4a - Text: #d4d4e4 (soft white, reduces eye strain vs pure #fff) - Links: #6cb6ff (distinguishable from body text) - Borders: #3a3a5c (subtle, consistent) Syntax highlighting: - Add complete dark mode token colors for all ~40 syntax classes - VS Code Dark+ inspired palette - Previously only 3 of ~40 tokens had dark overrides Bug fixes: - Fix table row text color (#333 on dark bg was unreadable) - Fix links being indistinguishable from body text (all were #fff) - Fix inline code having light border on dark background - Fix sidebar search area remaining white in dark mode - Fix toolbar border remaining light gray - Fix image inversion being too aggressive (now uses subtle opacity) New dark mode coverage: - Modals, admonitions (type-specific accents), homepage elements - Collapse/toggle bars, tooltips, anchor links, autodoc, footnotes - Non-QuantEcon project color overrides, toctree caption text UX improvements: - Eliminate FOUC with early dark mode injection script - SVG icons use currentColor instead of forced white - Images use subtle opacity reduction instead of aggressive inversion - Stderr warnings updated to match new palette * docs: add dark mode documentation and v0.17.1 release updates * docs: update CHANGELOG with dark theme overhaul changes * fix: address Copilot review feedback on dark theme PR - Flatten SCSS nesting to plain CSS in layout.html <style> tag (browsers can't parse SCSS) - Add missing semicolon in .toctree-wrapper .caption-text rule - Scope svg g selector to UI icon containers only (.qe-toolbar, .qe-sidebar, .topbar-main, nav) to avoid breaking matplotlib/plotly charts - Remove duplicate .highlight rules (unreachable :where() block) - Use strict equality (=== '1') in FOUC prevention script * UPDATE: Regenerate all visual snapshots (6 files) * ci: trigger CI and preview build * refactor: convert dark theme hardcoded colors to CSS custom properties Declare 16 CSS custom properties on body.dark-theme so downstream projects can override palette colors without duplicating selectors: --qe-dark-bg, --qe-dark-surface, --qe-dark-surface-alt, --qe-dark-border, --qe-dark-text, --qe-dark-text-muted, --qe-dark-heading, --qe-dark-heading-top, --qe-dark-text-light, --qe-dark-link, --qe-dark-link-hover, --qe-dark-link-visited, --qe-dark-code-bg, --qe-dark-inline-code, --qe-dark-accent, --qe-dark-accent-dark All ~120 hardcoded palette hex values replaced with var() references. Semantic colors (admonition accents, modal button text) remain hardcoded intentionally. Docs updated with full reference table of available properties. * fix: double logo in dark theme when dark_logo is configured The :only-child fallback was matching .logo-img:only-child, but each <img> is always the sole child of its own <a> wrapper, so it matched even when a dark logo existed — showing both logos. Fixed by checking :only-child on the <a> wrapper instead: p.logo > a:only-child > .logo-img When a dark logo IS configured there are two <a> siblings inside <p class="logo">, so a:only-child won't match and only the dark logo is shown. Fixes: double logo issue reported in PR #365 * fix: page header and changelog unreadable in dark theme The page header (title link, authors, 'Last changed' button) and the changelog dropdown used colors.$body (#444) which is invisible on the dark background. Added dark theme overrides for the full .qe-page__header section: - Title link → heading-top color - Authors → primary text - 'Last changed' button → muted text with accent border - Changelog dropdown → dark surface background, proper borders - Commit hash, author, time, message → appropriate text colors * docs: update CHANGELOG with recent dark theme fixes Add entries for: - CSS custom properties refactor (16 overridable --qe-dark-* vars) - Double logo fix (only-child selector bug) - Page header/changelog readability fix * fix: remove extra font-weight on links in dark theme The dark theme applied font-weight: 600 to .reference links, making them visually heavier than in light mode. Color alone provides sufficient contrast on dark backgrounds. --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.