Skip to content

[python_by_example] Remove the unnecessary text for matplotlib inline#272

Merged
mmcky merged 1 commit intomainfrom
test_matplotlib_magic
Apr 11, 2023
Merged

[python_by_example] Remove the unnecessary text for matplotlib inline#272
mmcky merged 1 commit intomainfrom
test_matplotlib_magic

Conversation

@HengchengZhang
Copy link
Copy Markdown
Member

Hi @jstac and @mmcky, this PR fix #271.

I've tested it in my local environment and it looks well after deleting the text.

@HengchengZhang HengchengZhang changed the title Removed the unnecessay text Remove the unnecessay text Apr 11, 2023
@github-actions
Copy link
Copy Markdown

@github-actions github-actions bot temporarily deployed to pull request April 11, 2023 04:20 Inactive
@jstac
Copy link
Copy Markdown
Contributor

jstac commented Apr 11, 2023

Nice work @HengchengZhang , many thanks.

Please fix the failing build or ping @mmcky if you're not sure what's happening.

@mmcky
Copy link
Copy Markdown
Contributor

mmcky commented Apr 11, 2023

@HengchengZhang would you mind to review the links that are reported as broken such as

(        about_py: line   85) broken    https://www.sciencedirect.com/science/article/pii/S1477388021000177 - 403 Client Error: Forbidden for url: https://www.sciencedirect.com/science/article/pii/S1477388021000177

there are a couple of additional ones in the GitHub actions output for the Link Checker

https://github.com/QuantEcon/lecture-python-programming.myst/actions/runs/4663763516/jobs/8255387311?pr=272

@HengchengZhang
Copy link
Copy Markdown
Member Author

Thanks @jstac and @mmcky, I checked these this afternoon but I think the broken links it gives all work actually.

@mmcky
Copy link
Copy Markdown
Contributor

mmcky commented Apr 11, 2023

Roger that - the false positives are annoying with the link checker. We may need to think about seeing if there are some checks we can skip to reduce the false positivity rate at some point.

@mmcky mmcky merged commit 46ef0b1 into main Apr 11, 2023
@mmcky mmcky deleted the test_matplotlib_magic branch April 11, 2023 10:28
@mmcky mmcky changed the title Remove the unnecessay text [python_by_example] Remove the unnecessay text for matplotlib inline Apr 11, 2023
@mmcky mmcky changed the title [python_by_example] Remove the unnecessay text for matplotlib inline [python_by_example] Remove the unnecessary text for matplotlib inline Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python by example lecture

3 participants