-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Fixes DockerfileLeanFoundation build and adds/updates new packages #5036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes DockerfileLeanFoundation build and adds/updates new packages #5036
Conversation
cf92b17 to
5b10505
Compare
* Updates DockerfileLeanFoundation packages and adds new packages * apt-get performance improvements
5b10505 to
a52eee3
Compare
Martin-Molinero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
* Updates all CDN downloads to HTTPS
Martin-Molinero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's re sanity test live/backtesting/research with refactor-4930-dockerfileleanfoundation-build-and-pkg-upgrade-e4ee305-fb5d480 10084
AlexCatarino
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the update, @gsalaz98 !
Hopefully, it will make our lives easier to add future libraries.
Hey @Sharma-Rajat! We will go through pending library requests in FIFO order |
Description
Fixes DockerfileLeanFoundation build and upgrades package versions.
This supersedes Alex's PR (#4465) by fixing the foundation.
Also, some performance upgrades have been made as part of this PR, mainly with the downloading of apt packages.
Most installs have been moved to pip, rather than conda to speed up installation and dependency resolution, as well as avoiding some dependency issues.
Related Issue
Closes #4930 (Foundation does not build)
Closes #4432 (FastAi2)
Closes #4430 (scikit.tda)
Closes #4408 (sklearn-json)
Closes #4395 (ppscore)
Closes #4388 (PyPortfolioOpt)
Closes #4374 (mpi4py)
Closes #4440 (catboost)
Closes #4468 (TA)
Motivation and Context
Ensure foundation builds and have new and upgraded packages
Requires Documentation Change
Yes - list of installed packages should be updated here: https://www.quantconnect.com/docs/key-concepts/supported-libraries#Supported-Libraries-Introduction
How Has This Been Tested?
Built Foundation and ran tests on Lean - all tests passing
Types of changes
Checklist:
bug-<issue#>-<description>orfeature-<issue#>-<description>