Conversation
Manason
previously approved these changes
Aug 29, 2024
mafewtm
previously approved these changes
Aug 30, 2024
c551e90 to
e05f262
Compare
2 tasks
mafewtm
approved these changes
Oct 2, 2024
Manason
approved these changes
Oct 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For Qbox-project/qbx_core#555, configure the message of the day to be the following by default:

Also configures service messages.
For example, with this service messages configuration:
[ { "version": "", "content": "empty string: will never show up" }, { "version": 1, "content": "number: will never show up" }, { "version": {}, "content": "empty object: will never show up" }, { "version": [], "content": "empty array: will never show up" }, { "version": true, "content": "true: will never show up" }, { "version": false, "content": "false: will always show up" }, { "version": null, "content": "null: will always show up" }, { "content": "undefined: will always show up" }, { "version": "1.", "content": "'1.': will show up for versions 1.x.x" }, { "version": "1.20.", "content": "'1.20.': will show up for versions 1.20.x" }, { "version": "1.20.1", "content": "'1.20.1': will show up for version 1.20.1" }, { "version": "2.", "content": "'2.': will show up for versions 2.x.x" }, { "version": ["1.19.", "1.20.1"], "content": [ "['1.19.', '1.20.1']: will show up for versions 1.19.x and version 1.20.1,", "plus all of these support multiline!" ] } ]You get this result:

Checklist