Skip to content

feat: motd#86

Merged
Manason merged 2 commits into
mainfrom
motd
Oct 3, 2024
Merged

feat: motd#86
Manason merged 2 commits into
mainfrom
motd

Conversation

@D4isDAVID

@D4isDAVID D4isDAVID commented Aug 29, 2024

Copy link
Copy Markdown
Member

Description

For Qbox-project/qbx_core#555, configure the message of the day to be the following by default:
image

Also configures service messages.
For example, with this service messages configuration:

[
    {
        "version": "",
        "content": "empty string: will never show up"
    },
    {
        "version": 1,
        "content": "number: will never show up"
    },
    {
        "version": {},
        "content": "empty object: will never show up"
    },
    {
        "version": [],
        "content": "empty array: will never show up"
    },
    {
        "version": true,
        "content": "true: will never show up"
    },
    {
        "version": false,
        "content": "false: will always show up"
    },
    {
        "version": null,
        "content": "null: will always show up"
    },
    {
        "content": "undefined: will always show up"
    },
    {
        "version": "1.",
        "content": "'1.': will show up for versions 1.x.x"
    },
    {
        "version": "1.20.",
        "content": "'1.20.': will show up for versions 1.20.x"
    },
    {
        "version": "1.20.1",
        "content": "'1.20.1': will show up for version 1.20.1"
    },
    {
        "version": "2.",
        "content": "'2.': will show up for versions 2.x.x"
    },
    {
        "version": ["1.19.", "1.20.1"],
        "content": [
            "['1.19.', '1.20.1']: will show up for versions 1.19.x and version 1.20.1,",
            "plus all of these support multiline!"
        ]
    }
]

You get this result:
image

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My pull request fits the contribution guidelines & code conventions.

Manason
Manason previously approved these changes Aug 29, 2024
Comment thread server.cfg Outdated
mafewtm
mafewtm previously approved these changes Aug 30, 2024
@D4isDAVID D4isDAVID marked this pull request as draft September 19, 2024 00:47
@D4isDAVID D4isDAVID changed the title feat(server.cfg): configure message of the day feat(server.cfg): motd Sep 19, 2024
@D4isDAVID D4isDAVID changed the title feat(server.cfg): motd feat: motd Oct 2, 2024
@D4isDAVID D4isDAVID force-pushed the motd branch 5 times, most recently from c551e90 to e05f262 Compare October 2, 2024 17:17
@D4isDAVID D4isDAVID mentioned this pull request Oct 2, 2024
2 tasks
@D4isDAVID D4isDAVID marked this pull request as ready for review October 2, 2024 18:36
@D4isDAVID D4isDAVID dismissed stale reviews from mafewtm and Manason October 2, 2024 18:36

stale

@Manason Manason merged commit f6627ff into main Oct 3, 2024
@mafewtm mafewtm deleted the motd branch October 3, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants