Skip to content

feat: motd#555

Merged
D4isDAVID merged 2 commits into
mainfrom
feature/welcome-messages
Oct 6, 2024
Merged

feat: motd#555
D4isDAVID merged 2 commits into
mainfrom
feature/welcome-messages

Conversation

@D4isDAVID

@D4isDAVID D4isDAVID commented Aug 29, 2024

Copy link
Copy Markdown
Member

Description

To improve the onboarding of newbies to Qbox, this PR adds:

  • Client MOTD sent in the chat after the player loads in; can be configured.
  • Server MOTD printed to the console after the server starts; can be disabled.
  • Service messages taken from the txAdminRecipe, repo printed to the console after the server starts; can be disabled.

Server MOTD example:
image

See client MOTD and service message examples here: Qbox-project/txAdminRecipe#86

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My pull request fits the contribution guidelines & code conventions.

Comment thread client/events.lua Outdated
Manason
Manason previously approved these changes Aug 29, 2024

@Manason Manason left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a line to the readme for this feature (and any other missing features in there while you are editing!)

Comment thread server/main.lua Outdated
solareon
solareon previously approved these changes Aug 29, 2024
@D4isDAVID D4isDAVID marked this pull request as draft September 19, 2024 01:06
@D4isDAVID D4isDAVID changed the title feat: welcome message and message of the day feat: motd Sep 19, 2024
@D4isDAVID D4isDAVID force-pushed the feature/welcome-messages branch from e818f33 to b7b4a7f Compare October 2, 2024 18:34
@D4isDAVID D4isDAVID marked this pull request as ready for review October 2, 2024 18:35
@D4isDAVID D4isDAVID requested review from Manason and solareon October 2, 2024 18:36
@D4isDAVID D4isDAVID dismissed stale reviews from solareon and Manason October 2, 2024 18:36

stale

Comment thread server/motd.lua
Comment thread server/motd.lua
@D4isDAVID D4isDAVID force-pushed the feature/welcome-messages branch from b7b4a7f to 3e72b12 Compare October 6, 2024 19:28
@D4isDAVID D4isDAVID merged commit 69dc663 into main Oct 6, 2024
@D4isDAVID D4isDAVID deleted the feature/welcome-messages branch October 6, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants