update docs to use security policy#3557
Conversation
…l to use the new ISecurityPolicy
stevepiercy
left a comment
There was a problem hiding this comment.
Suggested one wording change.
Otherwise LGTM so far.
I can probably run through the cookiecutter synch on Tuesday so that this PR can be finished.
|
Please do sync the cookiecutters. Waiting on that to finish this PR. |
|
Is your open PR finished? Pylons/pyramid-cookiecutter-starter#81 |
|
yes |
|
Not sure why you approved this - it isn't done yet. |
|
I approved work thusfar. I can do another one later, too. It sounds like you prefer one final review going forward, which I will do. |
|
It’s fine I guess. The PR is in draft mode meaning I don’t really care if anyone reviews it yet. |
|
I can sync the cookiecutters if you don’t have time. Just gotta let me know. |
|
I'm working on it. |
|
Ok! |
|
This PR depends on the completion of #3556 |
|
Ok, I've significantly updated the wiki2 tutorial.
I still need to sync the cookiecutter with wiki tutorial (I won't be nearly as detailed in my changes there unfortunately), and to review the security chapter documentation. There may also be some missing cookiecutter udpates in the starter project chapter. |
|
Lots of good stuff here. Thank you for this work! |
|
You need to install pyramid master into the virtualenv you create for the tutorial step. After that, you need to post an actual error message. |
Ensured that the source files in
|
|
You need to install this branch, not master. |
|
I do it with |
merwok
left a comment
There was a problem hiding this comment.
I read quick tuto and narrative docs for security: LGTM!
Yup, did that as well, both now and earlier, unless this is not the correct command to install this branch.
Still got the exact same error message as above. |
|
I tossed out my virtual environment, rebuilt the tutorial from scratch, and now all tests pass.
|
- Sync up wiki with language from wiki2
- Fix line number reference
|
Thanks @stevepiercy I think this PR is ready to be merged. |
|
Not yet. I still have the last two steps to do in the traversal wiki. Will do late tonight. |
- Swap order of editing tutorial/views/default.py so that line numbers in the user's editor align with the rendered docs
- Expand contractions and spell out words
|
OK, I'm done! Any final revisions? |
|
Thanks @stevepiercy and @merwok for your review! |
identifytoauthenticated_identityonISecurityPolicyrendered: https://mmerickel-pyramid-fork.readthedocs.io/en/security-docs/
fixes #3548