Skip to content

feat: Add mention property to BaseEmoji class#2972

Merged
Lulalaby merged 2 commits intoPycord-Development:masterfrom
Lumabots:emoji-mention
Oct 22, 2025
Merged

feat: Add mention property to BaseEmoji class#2972
Lulalaby merged 2 commits intoPycord-Development:masterfrom
Lumabots:emoji-mention

Conversation

@Lumabots
Copy link
Contributor

@Lumabots Lumabots commented Oct 22, 2025

Introduces a mention property to BaseEmoji, providing a formatted string for mentioning emojis in messages. Also fixes formatting in AppEmoji's repr method.

Summary

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Lumabots Lumabots requested a review from a team as a code owner October 22, 2025 09:08
@pycord-app
Copy link

pycord-app bot commented Oct 22, 2025

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/2972/head:pr-2972
git checkout pr-2972

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/2972/head

@Lumabots
Copy link
Contributor Author

i don't feel like this needs a changelog

@Lumabots Lumabots changed the title Add mention property to BaseEmoji class feat: Add mention property to BaseEmoji class Oct 22, 2025
@Lulalaby
Copy link
Member

It does

Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog

Introduces a mention property to BaseEmoji, providing a formatted string for mentioning emojis in messages. Also fixes formatting in AppEmoji's __repr__ method.
@Lulalaby Lulalaby requested review from a team as code owners October 22, 2025 09:57
@Lulalaby Lulalaby requested review from Icebluewolf, baronkobama and plun1331 and removed request for a team October 22, 2025 09:57
Lulalaby
Lulalaby approved these changes Oct 22, 2025
@Lulalaby Lulalaby merged commit 55efab4 into Pycord-Development:master Oct 22, 2025
25 of 27 checks passed
Lulalaby added a commit that referenced this pull request Oct 22, 2025
Lulalaby added a commit that referenced this pull request Oct 22, 2025
Revert "feat: Add mention property to BaseEmoji class (#2972)"

This reverts commit 55efab4.
Paillat-dev pushed a commit to Pycord-Development/pycord-next that referenced this pull request Oct 26, 2025
* Add mention property to BaseEmoji class

Introduces a mention property to BaseEmoji, providing a formatted string for mentioning emojis in messages. Also fixes formatting in AppEmoji's __repr__ method.

* chore: changelog

---------

Co-authored-by: Lala Sabathil <lala@pycord.dev>
(cherry picked from commit 55efab4)
Paillat-dev pushed a commit to Pycord-Development/pycord-next that referenced this pull request Oct 26, 2025
…pment#2973)

Revert "feat: Add mention property to BaseEmoji class (Pycord-Development#2972)"

This reverts commit 55efab4.

(cherry picked from commit c6109a5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants