feat: Add optional filter parameter to utils.basic_autocomplete#2590
Merged
Lulalaby merged 9 commits intoPycord-Development:masterfrom Sep 28, 2024
sweetbrulee:master
Merged
feat: Add optional filter parameter to utils.basic_autocomplete#2590Lulalaby merged 9 commits intoPycord-Development:masterfrom sweetbrulee:master
Lulalaby merged 9 commits intoPycord-Development:masterfrom
sweetbrulee:master
Conversation
plun1331
reviewed
Sep 25, 2024
Member
plun1331
left a comment
There was a problem hiding this comment.
i don't think check is the right word for this, maybe filter?
Contributor
Author
|
I totally agree with that. The only reason I chose the word |
plun1331
reviewed
Sep 26, 2024
JustaSqu1d
requested changes
Sep 26, 2024
Co-authored-by: JustaSqu1d <89910983+JustaSqu1d@users.noreply.github.com> Signed-off-by: Jeffrey Ruan <sparrowking002@gmail.com>
plun1331
previously approved these changes
Sep 26, 2024
JustaSqu1d
requested changes
Sep 26, 2024
Co-authored-by: JustaSqu1d <89910983+JustaSqu1d@users.noreply.github.com> Signed-off-by: plun1331 <plun1331@gmail.com>
plun1331
previously approved these changes
Sep 26, 2024
JustaSqu1d
requested changes
Sep 27, 2024
Member
JustaSqu1d
left a comment
There was a problem hiding this comment.
Add a usage example in the example section of the function's doc string
* Clarify the description of the ``filter`` parameter * Add usage examples for the ``filter`` parameter
auto-merge was automatically disabled
September 27, 2024 19:39
Head branch was pushed to by a user without write access
plun1331
approved these changes
Sep 27, 2024
Lulalaby
approved these changes
Sep 28, 2024
baribarton
pushed a commit
to baribarton/pycord-no-potential-reconnect
that referenced
this pull request
Oct 24, 2024
…rd-Development#2590) Signed-off-by: Jeffrey Ruan <sparrowking002@gmail.com> Signed-off-by: plun1331 <plun1331@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: JustaSqu1d <89910983+JustaSqu1d@users.noreply.github.com> Co-authored-by: plun1331 <plun1331@gmail.com>
OmLanke
pushed a commit
to OmLanke/pycord
that referenced
this pull request
Dec 16, 2024
…rd-Development#2590) Signed-off-by: Jeffrey Ruan <sparrowking002@gmail.com> Signed-off-by: plun1331 <plun1331@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: JustaSqu1d <89910983+JustaSqu1d@users.noreply.github.com> Co-authored-by: plun1331 <plun1331@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add optional
checkparameter inutils.basic_autocomplete.If
checkis provided withNone, a default check is used that includes items whose string representation starts with the user's input value, case-insensitive.Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.