Skip to content

ci: update UI tests for Rust 1.94#5859

Merged
davidhewitt merged 5 commits into
PyO3:mainfrom
davidhewitt:rust-1.94
Mar 6, 2026
Merged

ci: update UI tests for Rust 1.94#5859
davidhewitt merged 5 commits into
PyO3:mainfrom
davidhewitt:rust-1.94

Conversation

@davidhewitt

Copy link
Copy Markdown
Member

No description provided.

@davidhewitt davidhewitt enabled auto-merge March 6, 2026 09:57
@Tpt Tpt mentioned this pull request Mar 6, 2026
@bschoenmaeckers

Copy link
Copy Markdown
Member

The nightly fail is interesting. It warns that the try_trait_v2 feature is not used anymore. But I'm not aware this feature got stabilized.

  error: feature `try_trait_v2` is declared but not used
   --> src/lib.rs:4:42
    |
  4 |     feature(auto_traits, negative_impls, try_trait_v2, iter_advance_by)
    |                                          ^^^^^^^^^^^^
    |
    = note: `-D unused-features` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(unused_features)]`

@davidhewitt davidhewitt added this pull request to the merge queue Mar 6, 2026
@davidhewitt

Copy link
Copy Markdown
Member Author

Hmm, I was not able to reproduce the nightly failure locally. Let's see if it self-resolves...

@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 6, 2026
@davidhewitt

Copy link
Copy Markdown
Member Author

https://github.com/PyO3/pyo3/actions/runs/22759243738/job/66011539163#step:7:180

Error: Only ELF, Mach-o and PE containers can be introspected

I have noticed this is flaky recently; @Tpt any ideas? I can try to find a windows machine to test on if needed...

@davidhewitt

Copy link
Copy Markdown
Member Author

@Tpt I merged #5861 into here, so we can get CI moving again. If we want a different fix, can resolve after the merge.

@davidhewitt davidhewitt enabled auto-merge March 6, 2026 12:56
@Tpt

Tpt commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

@davidhewitt Not exact idea. Maybe maturin is building an archive instead of single binary. I am going to investigate that

@davidhewitt davidhewitt added this pull request to the merge queue Mar 6, 2026
Merged via the queue into PyO3:main with commit 4c9a55f Mar 6, 2026
41 of 44 checks passed
@davidhewitt davidhewitt deleted the rust-1.94 branch March 6, 2026 14:58
davidhewitt added a commit that referenced this pull request Mar 31, 2026
* update UI tests for Rust 1.94

* ci: debug windows introspection failure

* check path for failed object

* ensure file path for `test-introspection` is correct
davidhewitt added a commit that referenced this pull request Apr 2, 2026
* update UI tests for Rust 1.94

* ci: debug windows introspection failure

* check path for failed object

* ensure file path for `test-introspection` is correct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants