Skip to content

ci: Add test for minimum supported debug build of Python#5852

Merged
davidhewitt merged 2 commits into
PyO3:mainfrom
Embers-of-the-Fire:ci-debug-min-version
Jun 9, 2026
Merged

ci: Add test for minimum supported debug build of Python#5852
davidhewitt merged 2 commits into
PyO3:mainfrom
Embers-of-the-Fire:ci-debug-min-version

Conversation

@Embers-of-the-Fire

Copy link
Copy Markdown
Contributor

As per comment in #5847.

Makes sense. We should probably also add a Py_REF_DEBUG build to CI on the lowest supported Python version.

Note that the original debug build downloads prebuilt standalone binaries from python-build-standalone, but the prebuilt binaries are limited (for old versions). In the latest release there's only 3.10.19 available, and I could not find a 3.7 build in all releases.
This PR pins it to 3.10.19-3.14.3 from 20260211 release.

@ngoldbaum

Copy link
Copy Markdown
Contributor

In the latest release there's only 3.10.19 available

That's fine, 3.10 will be the minimum supported version soon enough. We're already way overdue for dropping 3.7 and 3.8 support.

@ngoldbaum

ngoldbaum commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

I'll defer to @davidhewitt on whether it's OK to add another CI job to the full CI matrix. I added a ci-build-full label to make the new job actually run in this PR. You'll need to push another commit to trigger the tests again.

@ngoldbaum

Copy link
Copy Markdown
Contributor

The docs build error should go away once #5854 goes in.

@Embers-of-the-Fire

Copy link
Copy Markdown
Contributor Author

The error seems to be irrelavent with the CI :(

@davidhewitt

Copy link
Copy Markdown
Member

I think #5859 will fix the CI issues.

I am also looking at #5447 which should make this PR simpler to land & maintain.

@Embers-of-the-Fire

Copy link
Copy Markdown
Contributor Author

I am also looking at #5447 which should make this PR simpler to land & maintain.

:) agreed. Relying on curls is less than ideal. I'll have an eye on that.

@davidhewitt

Copy link
Copy Markdown
Member

@Embers-of-the-Fire I think this should be ready to update against current main. Thanks for the patience!

Use astral-sh/setup-uv for both the existing test-debug and the new
test-debug-min-version job (Python 3.10+debug), following the approach
from PyO3#5447.

Assisted-by: deepseek:deepseek-v4-pro
Signed-off-by: Embers-of-the-Fire <stellarishs@163.com>
@Embers-of-the-Fire

Copy link
Copy Markdown
Contributor Author

@davidhewitt Updated. But the error shown in https://github.com/PyO3/pyo3/actions/runs/27054706739/job/79856801452?pr=5852 seems to be irrelavent with the CI change.

Comment thread .github/workflows/ci.yml Outdated
components: rust-src
- uses: astral-sh/setup-uv@v7
with:
python-version: "3.10+debug"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing locally I have some issues with 3.10+debug finding the correct environment to start up when run from uv in the PyO3 test suite (similar to #4813 (comment)), so let's bump this to 3.11 which seems to work locally for me

Suggested change
python-version: "3.10+debug"
python-version: "3.11+debug"

@davidhewitt davidhewitt added this pull request to the merge queue Jun 9, 2026
Merged via the queue into PyO3:main with commit c79ac0e Jun 9, 2026
88 of 90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants