Add an API to set rpath when using macOS system Python#4833
Merged
Conversation
1bb8ba1 to
0492f55
Compare
davidhewitt
approved these changes
Jan 1, 2025
davidhewitt
left a comment
Member
There was a problem hiding this comment.
This seems fine to me, thanks 👍
Member
|
Ah, CI failing. |
0492f55 to
8545853
Compare
8fc29a1 to
c467d9e
Compare
davidhewitt
pushed a commit
that referenced
this pull request
Jan 3, 2025
davidhewitt
pushed a commit
that referenced
this pull request
Jan 3, 2025
davidhewitt
pushed a commit
that referenced
this pull request
Jan 11, 2025
JeanArhancet
pushed a commit
to JeanArhancet/pyo3
that referenced
this pull request
Jan 17, 2025
geofft
added a commit
to geofft/pyo3
that referenced
this pull request
Feb 3, 2025
Relocatable Python installations like python-build-standalone have a similar need for an rpath as the macOS framework builds in Xcode. Furthermore, the platform on which you build your code is not really a function of the code itself. This change generalizes the recent `add_python_framework_link_args()` from PyO3#4833 to `add_python_link_args()`, which also does the right thing on python-build-standalone, and encourages everyone to set up a build.rs file that invokes it, whether or not they need it on their current machine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of rust-lang/cargo#9554 we can not do it automatically, I think adding an API is better than ask users to hardcode it in
build.rsor.cargo/config.toml.