Skip to content

Remove old_password support#922

Merged
methane merged 2 commits into
PyMySQL:masterfrom
methane:remove-old-password
Jan 3, 2021
Merged

Remove old_password support#922
methane merged 2 commits into
PyMySQL:masterfrom
methane:remove-old-password

Conversation

@methane

@methane methane commented Jan 3, 2021

Copy link
Copy Markdown
Member

No description provided.

@methane methane merged commit cd61e56 into PyMySQL:master Jan 3, 2021
@methane methane deleted the remove-old-password branch January 3, 2021 04:50
@AmericanY

AmericanY commented Apr 3, 2021

Copy link
Copy Markdown
Traceback (most recent call last):
  File "/root/american/script.py", line 95, in <module>
    trio.run(main, parser.parse_args())
  File "/usr/local/lib/python3.9/site-packages/trio/_core/_run.py", line 1932, in run
    raise runner.main_task_outcome.error
  File "/root/american/script.py", line 72, in main
    nurse.start_soon(
  File "/usr/local/lib/python3.9/site-packages/trio/_core/_run.py", line 815, in __aexit__
    raise combined_error_from_nursery
  File "/root/american/script.py", line 31, in worker
    async with trio_mysql.connect(host=ip, user=user, password=password, connect_timeout=2) as connection:
  File "/usr/local/lib/python3.9/site-packages/trio_mysql/connections.py", line 616, in __aenter__
    await self.connect()
  File "/usr/local/lib/python3.9/site-packages/trio_mysql/connections.py", line 670, in connect
    await self._request_authentication()
  File "/usr/local/lib/python3.9/site-packages/trio_mysql/connections.py", line 974, in _request_authentication
    data = _auth.scramble_old_password(self.password, self.salt) + b"\0"
AttributeError: module 'trio_mysql._auth' has no attribute 'scramble_old_password'

@methane @smurfix

@smurfix

smurfix commented Apr 3, 2021

Copy link
Copy Markdown

Thanks, I'll look into it

@AmericanY

Copy link
Copy Markdown

@smurfix You welcome. thanks as well :)

@any0n3

any0n3 commented Apr 4, 2021

Copy link
Copy Markdown

Me too having the same issue. please fix it

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants