Rename Github.get_organization argument login to org#3187
Merged
EnricoMi merged 2 commits intoPyGithub:mainfrom Feb 14, 2025
Merged
Rename Github.get_organization argument login to org#3187EnricoMi merged 2 commits intoPyGithub:mainfrom
Github.get_organization argument login to org#3187EnricoMi merged 2 commits intoPyGithub:mainfrom
Conversation
Felixoid
approved these changes
Feb 12, 2025
Collaborator
|
You are right, it is called |
Github.get_organization signature hint #3186Github.get_organization argument login to org
Contributor
Author
|
@EnricoMi it seems the docs build has failed, you might want to rerun it before merging |
|
IMHO: This was a breaking change and, as such, should have been a major version bump. While calling without arguments is not an issue, we have a wrapper class built to have retry logic with a generic function being passed and using the *kwargs, which this change ended up breaking. However, I am happy to see consistency between API docs and code. |
Erethon
added a commit
to fricklerhandwerk/nix-security-tracker
that referenced
this pull request
Jun 17, 2025
The `get_organization` method's named argument `login` was changed to `org` PyGithub/PyGithub#3187
Erethon
added a commit
to fricklerhandwerk/nix-security-tracker
that referenced
this pull request
Jun 17, 2025
The `get_organization` method's named argument `login` was changed to `org` PyGithub/PyGithub#3187
Erethon
added a commit
to NixOS/nix-security-tracker
that referenced
this pull request
Jun 17, 2025
The `get_organization` method's named argument `login` was changed to `org` PyGithub/PyGithub#3187
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3186.